[Libclc-dev] [PATCH] Add missing HAVE_LLVM define to fix build with latest llvm

[Pavel Ondračka via Libclc-dev]

2017-09-26 18:33 GMT+02:00 Jan Vesely <jan.vesely at rutgers.edu>:
> On Tue, 2017-09-26 at 16:05 +0200, Pavel Ondračka via Libclc-dev wrote:
>> Broken since r314111
>
> right, that patch was on top of llvm-3.9 branch.
> thanks.
>
>>
>> Signed-off-by: Pavel Ondračka <pavel.ondracka at gmail.com>
>> ---
>>  configure.py | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure.py b/configure.py
>> index cc4c84b..3dd8b0a 100755
>> --- a/configure.py
>> +++ b/configure.py
>> @@ -81,7 +81,8 @@ llvm_bindir = llvm_config(['--bindir'])
>>  llvm_core_libs = llvm_config(['--libs', 'core', 'bitreader', 'bitwriter']) + ' ' + \
>>                   llvm_system_libs + ' ' + \
>>                   llvm_config(['--ldflags'])
>> -llvm_cxxflags = llvm_config(['--cxxflags']) + ' -fno-exceptions -fno-rtti'
>> +llvm_cxxflags = llvm_config(['--cxxflags']) + ' -fno-exceptions -fno-rtti ' + \
>> +                '-DHAVE_LLVM=0x0%i' % llvm_int_version
>
> I think that '-DHAVE_LLVM=0x{:0=4}'.format(llvm_int_version) is the
> preferred/new way of formatting strings.
>
> Jan

Right, thanks for the feedback, this is definitelly more pythonic as
well as future-proof.
Updated patch on the way.
Pavel

>>  llvm_libdir = llvm_config(['--libdir'])
>>
>>  llvm_clang = os.path.join(llvm_bindir, 'clang')