[Libclc-dev] [PATCH 08/14] native_sin: Switch implementation to llvm intrinsic

[Jeroen Ketema via Libclc-dev]

> On 10 Nov 2017, at 21:26, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> 
> On Fri, 2017-11-10 at 20:56 +0100, Jeroen Ketema wrote:
>>> On 10 Nov 2017, at 20:01, Jan Vesely <jan.vesely at rutgers.edu> wrote:
>>> 
>>>> On Thu, 2017-11-09 at 22:17 +0100, Jeroen Ketema wrote:
>>>> All the “native_blah: Switch implementation to llvm intrinsic” patches LGTM.
>>> 
>>> iiuc, that covers patches 5,6,7,8,9,10. Do you plan to take a look at
>>> the others? 1,2,3 are needed before I can start pushing the above.
>>> 
>> 
>> 1, 2, and 3 means the patches that switch to a generic implementation
>> for the log, log2, and log10 intrinsics? If so, those three I also
>> okay’ed yesterday (after which the whole header discussion followed).
> 
> ah, right. thanks. may I assume it applies to v2 of 1 (native_log2 with
> the macros cleaned up a bit)?

That one looks good to me too.

>> 
>> The other patches I plan to look at once these are committed (it’s a
>> bit much too to get the complete picture in one go, also because some
>> other patches were mixed in)
> 
> I'll wait until I can get the amdgpu workaround as well to avoid
> breaking native_exp and AMD gpus.

Ok.

Jeroen

> 
> Jan
> 
>> 
>> Jeroen
>> 
>>> thanks,
>>> Jan
>>> 
>>>> 
>>>> Jeroen
>>>> 
>>>>> On 4 Nov 2017, at 00:07, Jan Vesely via Libclc-dev <libclc-dev at lists.llvm.org> wrote:
>>>>> 
>>>>> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
>>>>> ---
>>>>> generic/include/clc/math/native_sin.h | 10 +++++++++-
>>>>> generic/lib/SOURCES                   |  1 +
>>>>> generic/lib/math/native_sin.cl        |  7 +++++++
>>>>> 3 files changed, 17 insertions(+), 1 deletion(-)
>>>>> create mode 100644 generic/lib/math/native_sin.cl
>>>>> 
>>>>> diff --git a/generic/include/clc/math/native_sin.h b/generic/include/clc/math/native_sin.h
>>>>> index 569a051..1492fc2 100644
>>>>> --- a/generic/include/clc/math/native_sin.h
>>>>> +++ b/generic/include/clc/math/native_sin.h
>>>>> @@ -1 +1,9 @@
>>>>> -#define native_sin sin
>>>>> +#define __CLC_BODY <clc/math/unary_decl.inc>
>>>>> +#define __CLC_FUNCTION native_sin
>>>>> +#define __FLOAT_ONLY
>>>>> +
>>>>> +#include <clc/math/gentype.inc>
>>>>> +
>>>>> +#undef __FLOAT_ONLY
>>>>> +#undef __CLC_BODY
>>>>> +#undef __CLC_FUNCTION
>>>>> diff --git a/generic/lib/SOURCES b/generic/lib/SOURCES
>>>>> index 97244f3..d29390d 100644
>>>>> --- a/generic/lib/SOURCES
>>>>> +++ b/generic/lib/SOURCES
>>>>> @@ -125,6 +125,7 @@ math/native_exp2.cl
>>>>> math/native_log.cl
>>>>> math/native_log10.cl
>>>>> math/native_log2.cl
>>>>> +math/native_sin.cl
>>>>> math/tables.cl
>>>>> math/clc_nextafter.cl
>>>>> math/nextafter.cl
>>>>> diff --git a/generic/lib/math/native_sin.cl b/generic/lib/math/native_sin.cl
>>>>> new file mode 100644
>>>>> index 0000000..fd9232f
>>>>> --- /dev/null
>>>>> +++ b/generic/lib/math/native_sin.cl
>>>>> @@ -0,0 +1,7 @@
>>>>> +#include <clc/clc.h>
>>>>> +
>>>>> +#define __CLC_NATIVE_INTRINSIC sin
>>>>> +
>>>>> +#define __CLC_BODY <native_unary_intrinsic.inc>
>>>>> +#define __FLOAT_ONLY
>>>>> +#include <clc/math/gentype.inc>
>>>>> -- 
>>>>> 2.13.6
>>>>> 
>>>>> _______________________________________________
>>>>> Libclc-dev mailing list
>>>>> Libclc-dev at lists.llvm.org
>>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev
>>>> 
>>>> 
>> 
>>