[Libclc-dev] clang SVN r303370 broke libclc

[Jan Vesely via Libclc-dev]

On Tue, 2017-06-27 at 14:42 +0000, Liu, Yaxun (Sam) wrote:
> I am trying to build mesa with opencl enabled on Ubuntu 16.04 so that
> I can reproduce the issue, however I got some issue. After I build
> and install it, I cannot see the OpenCL icd for mesa under
> /etc/OpenCL/vendors.
> 
> Here is the command I use to build mesa:
> 
> ./autogen.sh --prefix=/usr --libdir=/usr/lib/x86_64-linux-gnu --with-
> llvm-prefix=/usr/llvm/x86_64-linux-gnu --enable-glx-tls --enable-
> texture-float --disable-xvmc --disable-nine --with-gallium-
> drivers=radeonsi,swrast --with-dri-drivers= --with-egl-
> platforms=x11,drm --enable-gles1 --enable-gles2 -enable-opencl
> CXXFLAGS="-O2" CFLAGS="-O2"
> make
> sudo make install
> 
> Can someone take a look if I missed something? Thanks.

I think you need --enable-opencl_icd as well, otherwise mesa provides
the root opencl library (LD_PRELOAD, or LD_LIBRARY_PATH should be
enough to make it work even without icd)

> 
> BTW my email was always bounced back from libclc-dev at lists.llvm.org.
> I tried to subscribe to it for several times but never got response.
> Can someone pass my email to the mailing list?

no idea how to do that.
AFAIK, Tom Stellard is the official maintainer of libclc. He might know
better.

regards,
Jan

> 
> Thanks.
> 
> Sam
> 
> -----Original Message-----
> From: Liu, Yaxun (Sam) 
> Sent: Thursday, June 22, 2017 4:39 PM
> To: 'Jan Vesely' <jan.vesely at rutgers.edu>; Michel Dänzer <michel at daenzer.net>
> Cc: libclc-dev at lists.llvm.org
> Subject: RE: [Libclc-dev] clang SVN r303370 broke libclc
> 
> Sorry for the delay. I am still working on it. I think the failure was due to some kernel argument metadata change.
> 
> Sam
> 
> -----Original Message-----
> From: Jan Vesely [mailto:jv356 at scarletmail.rutgers.edu] On Behalf Of Jan Vesely
> Sent: Thursday, June 22, 2017 11:31 AM
> To: Liu, Yaxun (Sam) <Yaxun.Liu at amd.com>; Michel Dänzer <michel at daenzer.net>
> Cc: libclc-dev at lists.llvm.org
> Subject: Re: [Libclc-dev] clang SVN r303370 broke libclc
> 
> Hi Sam,
> 
> is there any progress on this regression? I still see the test failing on my machine.
> 
> thanks,
> Jan
> 
> On Thu, 2017-05-25 at 10:18 -0400, Jan Vesely wrote:
> > you can find the tests here:
> > https://piglit.freedesktop.org/
> > 
> > it's fairly straightforward to setup. my run cmdline is:
> > 
> > OCL_ICD_VENDORS=/etc/OpenCL/vendors/mesa-git.icd python3 ./piglit run 
> > tests/cl.py -o results/turks_cl_`date`
> > 
> > the to generate html report I run:
> > 
> > ./piglit summary html summary/turks_cl results/turks_cl_*
> > 
> > it looks like this:
> > http://paul.rutgers.edu/~jv356/piglit/radeon-latest-5/problems.html
> > 
> > Jan
> > 
> > just fyi the 'set kernel argument for array' test is also local memory 
> > related.
> > 
> > On Thu, 2017-05-25 at 14:10 +0000, Liu, Yaxun (Sam) wrote:
> > > Is these tests part of libclc? How do I run them?
> > > 
> > > Sam
> > > 
> > > -----Original Message-----
> > > From: Michel Dänzer [mailto:michel at daenzer.net]
> > > Sent: Thursday, May 25, 2017 3:46 AM
> > > To: Jan Vesely <jan.vesely at rutgers.edu>; Liu, Yaxun (Sam) 
> > > <Yaxun.Liu at amd.com>
> > > Cc: libclc-dev at lists.llvm.org
> > > Subject: Re: [Libclc-dev] clang SVN r303370 broke libclc
> > > 
> > > On 25/05/17 06:14 AM, Jan Vesely via Libclc-dev wrote:
> > > > On Wed, 2017-05-24 at 16:22 -0400, Jan Vesely wrote:
> > > > > On Wed, 2017-05-24 at 18:13 +0900, Michel Dänzer via Libclc-dev wrote:
> > > > > > On 24/05/17 01:19 AM, Liu, Yaxun (Sam) wrote:
> > > > > > > I have fixed the issue by https://reviews.llvm.org/rL303644
> > > > > > 
> > > > > > Seems to work fine, thanks!
> > > > > 
> > > > > also seems to fix most of EG 670 opencl regressions.
> > > > 
> > > > while at the same time it introduces regression in "set kernel 
> > > > argument for array" subtest on Turks.
> > > 
> > > Actually, I'm also seeing that test and a bunch of local atomic tests fail. Reverting both of Sam's patches and rebuilding libclc and Mesa fixes them. Not sure why I wasn't seeing these failures before, but it looks like there's still an issue here.
> > > 
> > > 
> > > -- 
> > > Earthling Michel Dänzer               |               http://www.amd.com
> > > Libre software enthusiast             |             Mesa and X developer
> > > 

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/libclc-dev/attachments/20170627/961ebd25/attachment.sig>