[Libclc-dev] [PATCH 0/2] modf math builtin

[Jan Vesely via Libclc-dev]

On Wed, 2016-01-20 at 13:20 +0100, Pavel Ondračka wrote:
> Jan Vesely píše v Út 19. 01. 2016 v 15:37 -0500:
> > On Tue, 2016-01-19 at 20:12 +0000, Arsenault, Matthew via Libclc-
> > dev
> > wrote:
> > > I tested your patch with OpenCL conformance, and it passes.
> > > 
> > > The documentation's pseudocode also passes conformance, and emits
> > > superior code from using the v_trunc_* instructions.
> > 
> > I think it'd be nice to have the test in piglit as well.
> > 
> > Jan
> > 
> I have used piglit locally to test my implementation. Attached is the
> handcrafted test I used. I have no idea if it can be included like
> that. Sadly the math builtins generating framework would need some
> work
> to support tests for functions that have two outputs. I'll try to do
> it
> but it will take some time to improve my python skills.


Tom (added to CC) posted changes for fract long time ago [0].
I still think that having external kernel (like modf.inc) would be
nicer than python generator, but the two outputs problem is addressed
there.

Jan



[0]http://lists.freedesktop.org/archives/piglit/2015-April/015633.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/libclc-dev/attachments/20160120/13deb38b/attachment.sig>