[Libclc-dev] [PATCH 3/3] Implement radians builtin

Aaron Watry awatry at gmail.com
Wed Feb 25 16:26:49 PST 2015 

This looks fine to me.  Do we have any test cases for this?

--Aaron

On Tue, Feb 24, 2015 at 2:15 PM, Tom Stellard <thomas.stellard at amd.com>
wrote:

> ---
>  generic/include/clc/clc.h                 |  1 +
>  generic/include/clc/geometric/radians.h   | 24 +++++++++++++++++
>  generic/include/clc/geometric/radians.inc | 23 ++++++++++++++++
>  generic/lib/SOURCES                       |  1 +
>  generic/lib/geometric/radians.cl          | 45
> +++++++++++++++++++++++++++++++
>  5 files changed, 94 insertions(+)
>  create mode 100644 generic/include/clc/geometric/radians.h
>  create mode 100644 generic/include/clc/geometric/radians.inc
>  create mode 100644 generic/lib/geometric/radians.cl
>
> diff --git a/generic/include/clc/clc.h b/generic/include/clc/clc.h
> index 02ecc1c..2ff3b15 100644
> --- a/generic/include/clc/clc.h
> +++ b/generic/include/clc/clc.h
> @@ -114,6 +114,7 @@
>  #include <clc/geometric/dot.h>
>  #include <clc/geometric/length.h>
>  #include <clc/geometric/normalize.h>
> +#include <clc/geometric/radians.h>
>
>  /* 6.11.6 Relational Functions */
>  #include <clc/relational/all.h>
> diff --git a/generic/include/clc/geometric/radians.h
> b/generic/include/clc/geometric/radians.h
> new file mode 100644
> index 0000000..a0a22c7
> --- /dev/null
> +++ b/generic/include/clc/geometric/radians.h
> @@ -0,0 +1,24 @@
> +/*
> + * Copyright (c) 2014,2015 Advanced Micro Devices, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> + * of this software and associated documentation files (the "Software"),
> to deal
> + * in the Software without restriction, including without limitation the
> rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or
> sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> IN
> + * THE SOFTWARE.
> + */
> +
> +#define __CLC_BODY <clc/geometric/radians.inc>
> +#include <clc/geometric/floatn.inc>
> diff --git a/generic/include/clc/geometric/radians.inc
> b/generic/include/clc/geometric/radians.inc
> new file mode 100644
> index 0000000..4110e76
> --- /dev/null
> +++ b/generic/include/clc/geometric/radians.inc
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (c) 2014,2015 Advanced Micro Devices, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> + * of this software and associated documentation files (the "Software"),
> to deal
> + * in the Software without restriction, including without limitation the
> rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or
> sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> IN
> + * THE SOFTWARE.
> + */
> +
> +_CLC_OVERLOAD _CLC_DECL __CLC_FLOATN radians(__CLC_FLOATN x);
> diff --git a/generic/lib/SOURCES b/generic/lib/SOURCES
> index fd90781..c48687d 100644
> --- a/generic/lib/SOURCES
> +++ b/generic/lib/SOURCES
> @@ -33,6 +33,7 @@ geometric/degrees.cl
>  geometric/dot.cl
>  geometric/length.cl
>  geometric/normalize.cl
> +geometric/radians.cl
>  integer/abs.cl
>  integer/abs_diff.cl
>  integer/add_sat.cl
> diff --git a/generic/lib/geometric/radians.cl b/generic/lib/geometric/
> radians.cl
> new file mode 100644
> index 0000000..3838dd6
> --- /dev/null
> +++ b/generic/lib/geometric/radians.cl
> @@ -0,0 +1,45 @@
> +/*
> + * Copyright (c) 2014,2015 Advanced Micro Devices, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> + * of this software and associated documentation files (the "Software"),
> to deal
> + * in the Software without restriction, including without limitation the
> rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or
> sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> IN
> + * THE SOFTWARE.
> + */
> +
> +#include <clc/clc.h>
> +
> +#include "../clcmacro.h"
> +
> +_CLC_OVERLOAD _CLC_DEF float radians(float degrees) {
> +  // pi/180 = ~0.01745329251994329577 or 0x1.1df46a2529d39p-6 or
> 0x1.1df46ap-6F
> +  return 0x1.1df46ap-6F * degrees;
> +}
> +
> +_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, float, radians, float);
> +
> +
> +#ifdef cl_khr_fp64
> +#pragma OPENCL EXTENSION cl_khr_fp64 : enable
> +
> +_CLC_OVERLOAD _CLC_DEF double radians(double degrees) {
> +  // pi/180 = ~0.01745329251994329577 or 0x1.1df46a2529d39p-6 or
> 0x1.1df46ap-6F
> +  return 0x1.1df46a2529d39p-6 * degrees;
> +}
> +
> +_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, double, radians, double);
> +
> +#endif
> --
> 2.0.4
>
>
> _______________________________________________
> Libclc-dev mailing list
> Libclc-dev at pcc.me.uk
> http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libclc-dev/attachments/20150225/0002b875/attachment.html>

More information about the Libclc-dev mailing list