[Libclc-dev] [PATCH 1/3] Fix _F definitions
j.ketema at imperial.ac.uk
Thu May 29 14:54:22 PDT 2014
Tom suggested I get commit access. I’ve done so and committed my patches which add definitions.
It would be good if I could get an explicit ok on v2 of the exp patch or feedback on how to improve it. I’m not totally happy with my solution there.
Also some review the compilation fix would be good.
On 15 May 2014, at 14:20, Tom Stellard <tom at stellard.net> wrote:
> On Tue, May 13, 2014 at 04:28:28PM +0100, Jeroen Ketema wrote:
>> Gentle nudge.
> These all look OK, I will commit them.
>> On 04 May 2014, at 22:42, Jeroen Ketema <j.ketema at imperial.ac.uk> wrote:
>>> The 'f' was missing and, hence, the values were
>>> considered to be doubles instead of floats.
>>> generic/include/clc/float/definitions.h | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> diff --git a/generic/include/clc/float/definitions.h b/generic/include/clc/float/definitions.h
>>> index d6fee84..83bdd9d 100644
>>> --- a/generic/include/clc/float/definitions.h
>>> +++ b/generic/include/clc/float/definitions.h
>>> @@ -9,8 +9,8 @@
>>> #define FLT_MIN 0x1.0p-126f
>>> #define FLT_EPSILON 0x1.0p-23f
>>> -#define M_LOG2E_F 0x1.715476p+0
>>> -#define M_PI_F 0x1.921fb6p+1
>>> +#define M_LOG2E_F 0x1.715476p+0f
>>> +#define M_PI_F 0x1.921fb6p+1f
>>> #ifdef cl_khr_fp64
>>> 126.96.36.199 (Apple Git-48)
>> Libclc-dev mailing list
>> Libclc-dev at pcc.me.uk
More information about the Libclc-dev