[Libclc-dev] [PATCH] Remove unused include which breaks build after r210803

Jeroen Ketema j.ketema at imperial.ac.uk
Fri Jun 13 04:47:00 PDT 2014


Hi Tom,

Given your follow-up fix, is seems that the header file was actually needed (which I missed), but is now only included indirectly.

Maybe we should conditionally include either  "llvm/Support/system_error.h” or <system_error> with the defines you added?

Jeroen

On 12 Jun 2014, at 22:12, Tom Stellard <tom at stellard.net> wrote:

> On Thu, Jun 12, 2014 at 09:43:21PM +0100, Jeroen Ketema wrote:
>> Tested with llvm 3.4 and trunk. Not with llvm 3.3 (if that's still supported)
> 
> LGTM.
>> ---
>> utils/prepare-builtins.cpp | 1 -
>> 1 file changed, 1 deletion(-)
>> 
>> diff --git a/utils/prepare-builtins.cpp b/utils/prepare-builtins.cpp
>> index 28c3e49..3130d73 100644
>> --- a/utils/prepare-builtins.cpp
>> +++ b/utils/prepare-builtins.cpp
>> @@ -9,7 +9,6 @@
>> #include "llvm/Support/MemoryBuffer.h"
>> #include "llvm/Support/FileSystem.h"
>> #include "llvm/Support/raw_ostream.h"
>> -#include "llvm/Support/system_error.h"
>> #include "llvm/Support/ErrorOr.h"
>> #include "llvm/Support/ToolOutputFile.h"
>> #include "llvm/Config/config.h"
>> -- 
>> 1.8.5.2 (Apple Git-48)
>> 
>> 
>> _______________________________________________
>> Libclc-dev mailing list
>> Libclc-dev at pcc.me.uk
>> http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev





More information about the Libclc-dev mailing list