[libc-commits] [libc] Use execve syscall wrapper in execve.cpp (PR #223186)
Bhavesh M via libc-commits
libc-commits at lists.llvm.org
Sat Sep 12 15:29:46 PDT 2026
https://github.com/beamandala created https://github.com/llvm/llvm-project/pull/223186
None
>From 8b9636414043bc6d8f794ce363f01a2678aa9024 Mon Sep 17 00:00:00 2001
From: Bhavesh Mandalapu <mandalapubhavesh at gmail.com>
Date: Sat, 12 Sep 2026 17:27:09 -0500
Subject: [PATCH] Use execve syscall wrapper in execve.cpp
---
libc/src/unistd/linux/CMakeLists.txt | 6 ++++--
libc/src/unistd/linux/execve.cpp | 12 +++++-------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/libc/src/unistd/linux/CMakeLists.txt b/libc/src/unistd/linux/CMakeLists.txt
index 4ea7c8a2078d8..2f97d375d5018 100644
--- a/libc/src/unistd/linux/CMakeLists.txt
+++ b/libc/src/unistd/linux/CMakeLists.txt
@@ -226,8 +226,10 @@ add_entrypoint_object(
HDRS
../execve.h
DEPENDS
- libc.include.sys_syscall
- libc.src.__support.OSUtil.osutil
+ libc.src.__support.common
+ libc.src.__support.libc_errno
+ libc.src.__support.macros.config
+ libc.src.__support.OSUtil.linux.syscall_wrappers.execve
libc.src.errno.errno
)
diff --git a/libc/src/unistd/linux/execve.cpp b/libc/src/unistd/linux/execve.cpp
index 2214b6df493bd..a8240aaf874bc 100644
--- a/libc/src/unistd/linux/execve.cpp
+++ b/libc/src/unistd/linux/execve.cpp
@@ -8,27 +8,25 @@
#include "src/unistd/execve.h"
#include "src/__support/macros/config.h"
-#include "src/unistd/environ.h"
-#include "src/__support/OSUtil/syscall.h" // For internal syscall function.
+#include "src/__support/OSUtil/linux/syscall_wrappers/execve.h"
#include "src/__support/common.h"
#include "src/__support/libc_errno.h"
-#include <sys/syscall.h> // For syscall numbers.
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(int, execve,
(const char *path, char *const argv[], char *const envp[])) {
- int ret = LIBC_NAMESPACE::syscall_impl<int>(SYS_execve, path, argv, envp);
- if (ret < 0) {
- libc_errno = -ret;
+ auto ret = linux_syscalls::execve(path, argv, envp);
+ if (!ret) {
+ libc_errno = ret.error();
return -1;
}
// Control will not reach here on success but have a return statement will
// keep the compilers happy.
- return ret;
+ return *ret;
}
} // namespace LIBC_NAMESPACE_DECL
More information about the libc-commits
mailing list