[libc-commits] [libc] [llvm] [libc] Make fmaximum_num/fminimum_num functions use the emulated float128 type (PR #217409)
via libc-commits
libc-commits at lists.llvm.org
Fri Sep 4 00:32:09 PDT 2026
https://github.com/Sukumarsawant updated https://github.com/llvm/llvm-project/pull/217409
>From ce392ca2cf75a3f6103beb731edb4c6fc4188cbe Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Fri, 4 Sep 2026 12:49:35 +0530
Subject: [PATCH 1/4] fmaximunumf128 and fminimumnumf128
---
libc/config/baremetal/aarch64/entrypoints.txt | 4 ++--
libc/config/baremetal/arm/entrypoints.txt | 4 ++--
libc/config/baremetal/riscv/entrypoints.txt | 4 ++--
libc/config/darwin/aarch64/entrypoints.txt | 4 ++--
libc/config/darwin/x86_64/entrypoints.txt | 2 ++
libc/config/freebsd/x86_64/entrypoints.txt | 4 ++--
libc/config/gpu/amdgpu/entrypoints.txt | 2 ++
libc/config/gpu/nvptx/entrypoints.txt | 2 ++
libc/config/linux/aarch64/entrypoints.txt | 4 ++--
libc/config/linux/arm/entrypoints.txt | 2 ++
libc/config/linux/riscv/entrypoints.txt | 4 ++--
libc/config/linux/x86_64/entrypoints.txt | 4 ++--
libc/config/windows/entrypoints.txt | 2 ++
libc/shared/math/fmaximum_numf128.h | 6 ------
libc/shared/math/fminimum_numf128.h | 6 ------
libc/src/__support/math/CMakeLists.txt | 4 ++--
libc/src/__support/math/fmaximum_numf128.h | 11 ++++-------
libc/src/__support/math/fminimum_numf128.h | 11 ++++-------
libc/src/math/fmaximum_numf128.h | 5 +++++
libc/src/math/fminimum_numf128.h | 5 +++++
libc/src/math/generic/CMakeLists.txt | 2 ++
libc/src/math/generic/fmaximum_numf128.cpp | 5 ++++-
libc/src/math/generic/fminimum_numf128.cpp | 5 ++++-
libc/test/shared/shared_math_constexpr_test.cpp | 8 ++------
libc/test/shared/shared_math_test.cpp | 7 ++-----
libc/test/src/math/smoke/CMakeLists.txt | 2 ++
libc/test/src/math/smoke/fmaximum_numf128_test.cpp | 5 +++++
libc/test/src/math/smoke/fminimum_numf128_test.cpp | 5 +++++
utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 8 ++++++--
.../libc/test/src/math/smoke/BUILD.bazel | 6 ++++++
30 files changed, 84 insertions(+), 59 deletions(-)
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index 199ff005d5ced..a8fde0d8ad22c 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -432,6 +432,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximum_magl
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaximumf
libc.src.math.fmaximumf128
@@ -449,6 +450,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimum_magl
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminimumf
libc.src.math.fminimumf128
@@ -766,10 +768,8 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.ffmaf128
libc.src.math.fmaximum_mag_numf128
libc.src.math.fmaximum_magf128
- libc.src.math.fmaximum_numf128
libc.src.math.fminimum_mag_numf128
libc.src.math.fminimum_magf128
- libc.src.math.fminimum_numf128
libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index 9f901ada3fdb5..efdbd9ae8735f 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -444,6 +444,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximum_magl
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaximumf
libc.src.math.fmaximumf128
@@ -461,6 +462,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimum_magl
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminimumf
libc.src.math.fminimumf128
@@ -777,10 +779,8 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.ffmaf128
libc.src.math.fmaximum_mag_numf128
libc.src.math.fmaximum_magf128
- libc.src.math.fmaximum_numf128
libc.src.math.fminimum_mag_numf128
libc.src.math.fminimum_magf128
- libc.src.math.fminimum_numf128
libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index f46c3b9a29ae6..c31c33c3c3c42 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -440,6 +440,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximum_magl
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaximumf
libc.src.math.fmaximumf128
@@ -457,6 +458,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimum_magl
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminimumf
libc.src.math.fminimumf128
@@ -774,10 +776,8 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.ffmaf128
libc.src.math.fmaximum_mag_numf128
libc.src.math.fmaximum_magf128
- libc.src.math.fmaximum_numf128
libc.src.math.fminimum_mag_numf128
libc.src.math.fminimum_magf128
- libc.src.math.fminimum_numf128
# libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index e418a92bf9356..a681cf8890603 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -251,6 +251,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximum_magl
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaximumf
libc.src.math.fmaximumf128
@@ -268,6 +269,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimum_magl
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminimumf
libc.src.math.fminimumf128
@@ -586,10 +588,8 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.ffmaf128
libc.src.math.fmaximum_mag_numf128
libc.src.math.fmaximum_magf128
- libc.src.math.fmaximum_numf128
libc.src.math.fminimum_mag_numf128
libc.src.math.fminimum_magf128
- libc.src.math.fminimum_numf128
libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index c41165b5b4fd9..24d74acb9fde2 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -158,11 +158,13 @@ set(TARGET_LIBM_ENTRYPOINTS
#libc.src.math.fmax
#libc.src.math.fmaxf
#libc.src.math.fmaxf128
+ #libc.src.math.fmaximum_numf128
#libc.src.math.fmaximumf128
#libc.src.math.fmaxl
#libc.src.math.fmin
#libc.src.math.fminf
#libc.src.math.fminf128
+ #libc.src.math.fminimum_numf128
#libc.src.math.fminimumf128
#libc.src.math.fminl
#libc.src.math.fmod
diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt
index 51d5c995faef0..5cc09152a5d0b 100644
--- a/libc/config/freebsd/x86_64/entrypoints.txt
+++ b/libc/config/freebsd/x86_64/entrypoints.txt
@@ -187,6 +187,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximuml
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaximum_mag
libc.src.math.fmaximum_magf
@@ -200,6 +201,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimuml
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminimum_mag
libc.src.math.fminimum_magf
@@ -526,10 +528,8 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.ffmaf128
libc.src.math.fmaximum_mag_numf128
libc.src.math.fmaximum_magf128
- libc.src.math.fmaximum_numf128
libc.src.math.fminimum_mag_numf128
libc.src.math.fminimum_magf128
- libc.src.math.fminimum_numf128
libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index 88f80d669f48b..e3e560331f3c2 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -382,6 +382,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximum_mag_numl
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaxl
libc.src.math.fmin
@@ -399,6 +400,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimum_mag_numl
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminl
libc.src.math.fmod
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index f3fdde41ecd20..d9b635fd6db82 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -378,6 +378,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximum_mag_numl
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaxl
libc.src.math.fmin
@@ -395,6 +396,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimum_mag_numl
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminl
libc.src.math.fmod
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index fbd9239728bac..a80dfd2ad3afc 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -609,6 +609,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximum_magl
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaximumf
libc.src.math.fmaximumf128
@@ -626,6 +627,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimum_magl
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminimumf
libc.src.math.fminimumf128
@@ -937,10 +939,8 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.ffmaf128
libc.src.math.fmaximum_mag_numf128
libc.src.math.fmaximum_magf128
- libc.src.math.fmaximum_numf128
libc.src.math.fminimum_mag_numf128
libc.src.math.fminimum_magf128
- libc.src.math.fminimum_numf128
libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 3a23742162e46..04551e33d80f4 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -434,6 +434,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximum_magl
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaximumf
libc.src.math.fmaximumf128
@@ -451,6 +452,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimum_magl
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminimumf
libc.src.math.fminimumf128
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index bd906c6900008..b7dd407d58ac8 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -678,6 +678,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximum_magl
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaximumf
libc.src.math.fmaximumf128
@@ -695,6 +696,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimum_magl
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminimumf
libc.src.math.fminimumf128
@@ -1023,10 +1025,8 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.ffmaf128
libc.src.math.fmaximum_mag_numf128
libc.src.math.fmaximum_magf128
- libc.src.math.fmaximum_numf128
libc.src.math.fminimum_mag_numf128
libc.src.math.fminimum_magf128
- libc.src.math.fminimum_numf128
libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index e6aeb3abe0672..0d2678d27f4e7 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -687,6 +687,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximum_magl
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaximumf
libc.src.math.fmaximumf128
@@ -704,6 +705,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimum_magl
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminimumf
libc.src.math.fminimumf128
@@ -1032,10 +1034,8 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.ffmaf128
libc.src.math.fmaximum_mag_numf128
libc.src.math.fmaximum_magf128
- libc.src.math.fmaximum_numf128
libc.src.math.fminimum_mag_numf128
libc.src.math.fminimum_magf128
- libc.src.math.fminimum_numf128
libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index dbbe08a1b77db..d1196d504ff9e 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -220,6 +220,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmaximuml
libc.src.math.fmaximum_num
libc.src.math.fmaximum_numf
+ libc.src.math.fmaximum_numf128
libc.src.math.fmaximum_numl
libc.src.math.fmaximum_mag
libc.src.math.fmaximum_magf
@@ -233,6 +234,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminimuml
libc.src.math.fminimum_num
libc.src.math.fminimum_numf
+ libc.src.math.fminimum_numf128
libc.src.math.fminimum_numl
libc.src.math.fminimum_mag
libc.src.math.fminimum_magf
diff --git a/libc/shared/math/fmaximum_numf128.h b/libc/shared/math/fmaximum_numf128.h
index f26724d537a3f..50557e8d25a14 100644
--- a/libc/shared/math/fmaximum_numf128.h
+++ b/libc/shared/math/fmaximum_numf128.h
@@ -9,10 +9,6 @@
#ifndef LLVM_LIBC_SHARED_MATH_FMAXIMUM_NUMF128_H
#define LLVM_LIBC_SHARED_MATH_FMAXIMUM_NUMF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "shared/libc_common.h"
#include "src/__support/math/fmaximum_numf128.h"
@@ -24,6 +20,4 @@ using math::fmaximum_numf128;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SHARED_MATH_FMAXIMUM_NUMF128_H
diff --git a/libc/shared/math/fminimum_numf128.h b/libc/shared/math/fminimum_numf128.h
index dcacd52b18a12..e654f0025bdf6 100644
--- a/libc/shared/math/fminimum_numf128.h
+++ b/libc/shared/math/fminimum_numf128.h
@@ -9,10 +9,6 @@
#ifndef LLVM_LIBC_SHARED_MATH_FMINIMUM_NUMF128_H
#define LLVM_LIBC_SHARED_MATH_FMINIMUM_NUMF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "shared/libc_common.h"
#include "src/__support/math/fminimum_numf128.h"
@@ -24,6 +20,4 @@ using math::fminimum_numf128;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SHARED_MATH_FMINIMUM_NUMF128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 25489d60383a1..0f2fc3584c786 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -1052,7 +1052,7 @@ add_header_library(
HDRS
fmaximum_numf128.h
DEPENDS
- libc.include.llvm-libc-types.float128
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.basic_operations
libc.src.__support.macros.config
)
@@ -1358,7 +1358,7 @@ add_header_library(
HDRS
fminimum_numf128.h
DEPENDS
- libc.include.llvm-libc-types.float128
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.basic_operations
libc.src.__support.macros.config
)
diff --git a/libc/src/__support/math/fmaximum_numf128.h b/libc/src/__support/math/fmaximum_numf128.h
index ccee570de2c14..f81f851201538 100644
--- a/libc/src/__support/math/fmaximum_numf128.h
+++ b/libc/src/__support/math/fmaximum_numf128.h
@@ -9,23 +9,20 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_NUMF128_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_NUMF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "src/__support/FPUtil/BasicOperations.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
namespace math {
-LIBC_INLINE constexpr float128 fmaximum_numf128(float128 x, float128 y) {
+using LIBC_NAMESPACE::fputil::Float128;
+
+LIBC_INLINE constexpr Float128 fmaximum_numf128(Float128 x, Float128 y) {
return fputil::fmaximum_num(x, y);
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_NUMF128_H
diff --git a/libc/src/__support/math/fminimum_numf128.h b/libc/src/__support/math/fminimum_numf128.h
index 6f3ac894a7d2b..607eae7ee0e6b 100644
--- a/libc/src/__support/math/fminimum_numf128.h
+++ b/libc/src/__support/math/fminimum_numf128.h
@@ -9,23 +9,20 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUM_NUMF128_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUM_NUMF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "src/__support/FPUtil/BasicOperations.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
namespace math {
-LIBC_INLINE constexpr float128 fminimum_numf128(float128 x, float128 y) {
+using LIBC_NAMESPACE::fputil::Float128;
+
+LIBC_INLINE constexpr Float128 fminimum_numf128(Float128 x, Float128 y) {
return fputil::fminimum_num(x, y);
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUM_NUMF128_H
diff --git a/libc/src/math/fmaximum_numf128.h b/libc/src/math/fmaximum_numf128.h
index 1e9bd8dfb81aa..a4afa4f7b2241 100644
--- a/libc/src/math/fmaximum_numf128.h
+++ b/libc/src/math/fmaximum_numf128.h
@@ -10,11 +10,16 @@
#ifndef LLVM_LIBC_SRC_MATH_FMAXIMUM_NUMF128_H
#define LLVM_LIBC_SRC_MATH_FMAXIMUM_NUMF128_H
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
namespace LIBC_NAMESPACE_DECL {
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
float128 fmaximum_numf128(float128 x, float128 y);
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/fminimum_numf128.h b/libc/src/math/fminimum_numf128.h
index 1833e9e1c9f5c..3b02a6519e037 100644
--- a/libc/src/math/fminimum_numf128.h
+++ b/libc/src/math/fminimum_numf128.h
@@ -10,11 +10,16 @@
#ifndef LLVM_LIBC_SRC_MATH_FMINIMUM_NUMF128_H
#define LLVM_LIBC_SRC_MATH_FMINIMUM_NUMF128_H
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
namespace LIBC_NAMESPACE_DECL {
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
float128 fminimum_numf128(float128 x, float128 y);
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 6a144ba0c3d3b..a62954c97d553 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -2246,6 +2246,7 @@ add_entrypoint_object(
HDRS
../fmaximum_numf128.h
DEPENDS
+ libc.src.__support.CPP.bit
libc.src.__support.math.fmaximum_numf128
)
@@ -2487,6 +2488,7 @@ add_entrypoint_object(
HDRS
../fminimum_numf128.h
DEPENDS
+ libc.src.__support.CPP.bit
libc.src.__support.math.fminimum_numf128
)
diff --git a/libc/src/math/generic/fmaximum_numf128.cpp b/libc/src/math/generic/fmaximum_numf128.cpp
index e6bae7947371d..950ecfba878b7 100644
--- a/libc/src/math/generic/fmaximum_numf128.cpp
+++ b/libc/src/math/generic/fmaximum_numf128.cpp
@@ -7,12 +7,15 @@
//===----------------------------------------------------------------------===//
#include "src/math/fmaximum_numf128.h"
+#include "src/__support/CPP/bit.h"
#include "src/__support/math/fmaximum_numf128.h"
namespace LIBC_NAMESPACE_DECL {
+using LIBC_NAMESPACE::fputil::Float128;
+
LLVM_LIBC_FUNCTION(float128, fmaximum_numf128, (float128 x, float128 y)) {
- return math::fmaximum_numf128(x, y);
+ return cpp::bit_cast<float128>(math::fmaximum_numf128(cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y)));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/generic/fminimum_numf128.cpp b/libc/src/math/generic/fminimum_numf128.cpp
index fec526cd19c41..ea67b0213f648 100644
--- a/libc/src/math/generic/fminimum_numf128.cpp
+++ b/libc/src/math/generic/fminimum_numf128.cpp
@@ -7,12 +7,15 @@
//===----------------------------------------------------------------------===//
#include "src/math/fminimum_numf128.h"
+#include "src/__support/CPP/bit.h"
#include "src/__support/math/fminimum_numf128.h"
namespace LIBC_NAMESPACE_DECL {
+using LIBC_NAMESPACE::fputil::Float128;
+
LLVM_LIBC_FUNCTION(float128, fminimum_numf128, (float128 x, float128 y)) {
- return math::fminimum_numf128(x, y);
+ return cpp::bit_cast<float128>(math::fminimum_numf128(cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y)));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index e9a9791529e59..8eb1261d88ebc 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,6 +381,8 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+static_assert(float128(0.0) == LIBC_NAMESPACE::shared::fminimum_numf128(Float128(0.0), Float128(0.0)));
+static_assert(float128(0.0) == LIBC_NAMESPACE::shared::fmaximum_numf128(Float128(0.0), Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::copysignf128(Float128(0.0),
Float128(0.0)));
@@ -437,12 +439,6 @@ static_assert(float128(1.0) ==
static_assert(0.0f ==
LIBC_NAMESPACE::shared::fdivf128(float128(0.0), float128(1.0)));
static_assert(0.0 == LIBC_NAMESPACE::shared::dsqrtf128(float128(0.0)));
-static_assert(float128(0.0) ==
- LIBC_NAMESPACE::shared::fmaximum_numf128(float128(0.0),
- float128(0.0)));
-static_assert(float128(0.0) ==
- LIBC_NAMESPACE::shared::fminimum_numf128(float128(0.0),
- float128(0.0)));
static_assert(float128(0.0) ==
LIBC_NAMESPACE::shared::fromfpf128(float128(0.0), 0, 32));
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index b1a3041947c86..719e8a900ca8d 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -584,6 +584,8 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+ EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128( Float128(0.0), Float128(0.0)));
+#endif // LIBC_TYPES_HAS_FLOAT16 EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128( Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::copysignf128(
Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fabsf128(Float128(0.0)));
@@ -705,11 +707,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
EXPECT_FP_EQ(
0.0f16, LIBC_NAMESPACE::shared::f16subf128(float128(0.0), float128(0.0)));
EXPECT_FP_EQ(0.0f16, LIBC_NAMESPACE::shared::f16sqrtf128(float128(0.0)));
-#endif // LIBC_TYPES_HAS_FLOAT16
- EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128(
- float128(0.0), float128(0.0)));
- EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128(
- float128(0.0), float128(0.0)));
EXPECT_FP_EQ(float128(0.0),
LIBC_NAMESPACE::shared::fromfpf128(float128(0.0), 0, 32));
EXPECT_FP_EQ(float128(0.0),
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 548554299bd8c..9f9cfa95d2f27 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -3005,6 +3005,7 @@ add_fp_unittest(
DEPENDS
libc.src.math.fmaximum_numf128
libc.src.__support.CPP.algorithm
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.fp_bits
)
@@ -3349,6 +3350,7 @@ add_fp_unittest(
HDRS
FMinimumNumTest.h
DEPENDS
+ libc.src.__support.FPUtil.float128
libc.src.math.fminimum_numf128
libc.src.__support.CPP.algorithm
libc.src.__support.FPUtil.fp_bits
diff --git a/libc/test/src/math/smoke/fmaximum_numf128_test.cpp b/libc/test/src/math/smoke/fmaximum_numf128_test.cpp
index 6855ea3b39a9c..2e870609b3fee 100644
--- a/libc/test/src/math/smoke/fmaximum_numf128_test.cpp
+++ b/libc/test/src/math/smoke/fmaximum_numf128_test.cpp
@@ -8,6 +8,11 @@
#include "FMaximumNumTest.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/fmaximum_numf128.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
LIST_FMAXIMUM_NUM_TESTS(float128, LIBC_NAMESPACE::fmaximum_numf128)
diff --git a/libc/test/src/math/smoke/fminimum_numf128_test.cpp b/libc/test/src/math/smoke/fminimum_numf128_test.cpp
index d773d8973286e..863e177b06cbe 100644
--- a/libc/test/src/math/smoke/fminimum_numf128_test.cpp
+++ b/libc/test/src/math/smoke/fminimum_numf128_test.cpp
@@ -7,7 +7,12 @@
//===----------------------------------------------------------------------===//
#include "FMinimumNumTest.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/fminimum_numf128.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
LIST_FMINIMUM_NUM_TESTS(float128, LIBC_NAMESPACE::fminimum_numf128)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index b7325b213ad7a..af4dcbf35310a 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -5615,8 +5615,8 @@ libc_support_library(
hdrs = ["src/__support/math/fmaximum_numf128.h"],
deps = [
":__support_fputil_basic_operations",
+ ":__support_fputil_float128",
":__support_macros_config",
- ":llvm_libc_types_float128",
],
)
@@ -5891,8 +5891,8 @@ libc_support_library(
hdrs = ["src/__support/math/fminimum_numf128.h"],
deps = [
":__support_fputil_basic_operations",
+ ":__support_fputil_float128",
":__support_macros_config",
- ":llvm_libc_types_float128",
],
)
@@ -12044,6 +12044,8 @@ libc_math_function(
libc_math_function(
name = "fmaximum_numf128",
additional_deps = [
+ ":__support_cpp_bit",
+ ":__support_fputil_float128",
":__support_math_fmaximum_numf128",
],
)
@@ -12223,6 +12225,8 @@ libc_math_function(
libc_math_function(
name = "fminimum_numf128",
additional_deps = [
+ ":__support_cpp_bit",
+ ":__support_fputil_float128",
":__support_math_fminimum_numf128",
],
)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
index aba43a2ea5a61..b98db6861ba7b 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
@@ -637,6 +637,9 @@ math_test(
math_test(
name = "fmaximum_numf128",
hdrs = ["FMaximumNumTest.h"],
+ deps = [
+ "//libc:__support_fputil_float128",
+ ],
)
math_test(
@@ -778,6 +781,9 @@ math_test(
math_test(
name = "fminimum_numf128",
hdrs = ["FMinimumNumTest.h"],
+ deps = [
+ "//libc:__support_fputil_float128",
+ ],
)
math_test(
>From 152b2402e4c3dd3217911de1026fe6d1ff0c058c Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Fri, 4 Sep 2026 12:50:13 +0530
Subject: [PATCH 2/4] clang-format
---
libc/src/math/generic/fmaximum_numf128.cpp | 3 ++-
libc/src/math/generic/fminimum_numf128.cpp | 3 ++-
libc/test/shared/shared_math_constexpr_test.cpp | 8 ++++++--
libc/test/shared/shared_math_test.cpp | 7 +++++--
4 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/libc/src/math/generic/fmaximum_numf128.cpp b/libc/src/math/generic/fmaximum_numf128.cpp
index 950ecfba878b7..fb164d4f98a18 100644
--- a/libc/src/math/generic/fmaximum_numf128.cpp
+++ b/libc/src/math/generic/fmaximum_numf128.cpp
@@ -15,7 +15,8 @@ namespace LIBC_NAMESPACE_DECL {
using LIBC_NAMESPACE::fputil::Float128;
LLVM_LIBC_FUNCTION(float128, fmaximum_numf128, (float128 x, float128 y)) {
- return cpp::bit_cast<float128>(math::fmaximum_numf128(cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y)));
+ return cpp::bit_cast<float128>(math::fmaximum_numf128(
+ cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y)));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/generic/fminimum_numf128.cpp b/libc/src/math/generic/fminimum_numf128.cpp
index ea67b0213f648..793d3e6041a52 100644
--- a/libc/src/math/generic/fminimum_numf128.cpp
+++ b/libc/src/math/generic/fminimum_numf128.cpp
@@ -15,7 +15,8 @@ namespace LIBC_NAMESPACE_DECL {
using LIBC_NAMESPACE::fputil::Float128;
LLVM_LIBC_FUNCTION(float128, fminimum_numf128, (float128 x, float128 y)) {
- return cpp::bit_cast<float128>(math::fminimum_numf128(cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y)));
+ return cpp::bit_cast<float128>(math::fminimum_numf128(
+ cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y)));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index 8eb1261d88ebc..5833996b0dd9f 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,8 +381,12 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
-static_assert(float128(0.0) == LIBC_NAMESPACE::shared::fminimum_numf128(Float128(0.0), Float128(0.0)));
-static_assert(float128(0.0) == LIBC_NAMESPACE::shared::fmaximum_numf128(Float128(0.0), Float128(0.0)));
+static_assert(float128(0.0) ==
+ LIBC_NAMESPACE::shared::fminimum_numf128(Float128(0.0),
+ Float128(0.0)));
+static_assert(float128(0.0) ==
+ LIBC_NAMESPACE::shared::fmaximum_numf128(Float128(0.0),
+ Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::copysignf128(Float128(0.0),
Float128(0.0)));
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 719e8a900ca8d..4f928d292c6cf 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -584,8 +584,11 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
- EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128( Float128(0.0), Float128(0.0)));
-#endif // LIBC_TYPES_HAS_FLOAT16 EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128( Float128(0.0), Float128(0.0)));
+ EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128(
+ Float128(0.0), Float128(0.0)));
+#endif // LIBC_TYPES_HAS_FLOAT16 EXPECT_FP_EQ(float128(0.0),
+ // LIBC_NAMESPACE::shared::fmaximum_numf128( Float128(0.0),
+ // Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::copysignf128(
Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fabsf128(Float128(0.0)));
>From 2973d76ac24867e8bdd14b4e787228b43588c04b Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Fri, 4 Sep 2026 12:57:52 +0530
Subject: [PATCH 3/4] nit
---
libc/src/__support/math/CMakeLists.txt | 4 ++--
libc/test/shared/shared_math_constexpr_test.cpp | 12 ++++++------
libc/test/shared/shared_math_test.cpp | 10 +++++-----
libc/test/src/math/smoke/CMakeLists.txt | 2 +-
libc/test/src/math/smoke/fminimum_numf128_test.cpp | 2 +-
5 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 0f2fc3584c786..4e6a13e36e98a 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -1052,8 +1052,8 @@ add_header_library(
HDRS
fmaximum_numf128.h
DEPENDS
- libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.basic_operations
+ libc.src.__support.FPUtil.float128
libc.src.__support.macros.config
)
@@ -1358,8 +1358,8 @@ add_header_library(
HDRS
fminimum_numf128.h
DEPENDS
- libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.basic_operations
+ libc.src.__support.FPUtil.float128
libc.src.__support.macros.config
)
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index 5833996b0dd9f..e3cca0d15a4ea 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,12 +381,6 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
-static_assert(float128(0.0) ==
- LIBC_NAMESPACE::shared::fminimum_numf128(Float128(0.0),
- Float128(0.0)));
-static_assert(float128(0.0) ==
- LIBC_NAMESPACE::shared::fmaximum_numf128(Float128(0.0),
- Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::copysignf128(Float128(0.0),
Float128(0.0)));
@@ -404,6 +398,12 @@ static_assert(Float128(0.0) ==
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::fminimumf128(Float128(0.0),
Float128(0.0)));
+static_assert(Float128(0.0) ==
+ LIBC_NAMESPACE::shared::fmaximum_numf128(Float128(0.0),
+ Float128(0.0)));
+static_assert(Float128(0.0) ==
+ LIBC_NAMESPACE::shared::fminimum_numf128(Float128(0.0),
+ Float128(0.0)));
static_assert(1 == LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
static_assert(0 == LIBC_NAMESPACE::shared::isnanf128(Float128(0.0)));
static_assert(0.0 == LIBC_NAMESPACE::shared::issignalingf128(Float128(0.0)));
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 4f928d292c6cf..f27145ca2ce26 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -584,11 +584,6 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
- EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128(
- Float128(0.0), Float128(0.0)));
-#endif // LIBC_TYPES_HAS_FLOAT16 EXPECT_FP_EQ(float128(0.0),
- // LIBC_NAMESPACE::shared::fmaximum_numf128( Float128(0.0),
- // Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::copysignf128(
Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fabsf128(Float128(0.0)));
@@ -601,6 +596,10 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminimumf128(
Float128(0.0), Float128(0.0)));
+ EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128(
+ Float128(0.0), Float128(0.0)));
+ EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128(
+ Float128(0.0), Float128(0.0)));
EXPECT_EQ(1, LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
EXPECT_EQ(0, LIBC_NAMESPACE::shared::isnanf128(Float128(0.0)));
EXPECT_EQ(0, LIBC_NAMESPACE::shared::issignalingf128(Float128(0.0)));
@@ -710,6 +709,7 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
EXPECT_FP_EQ(
0.0f16, LIBC_NAMESPACE::shared::f16subf128(float128(0.0), float128(0.0)));
EXPECT_FP_EQ(0.0f16, LIBC_NAMESPACE::shared::f16sqrtf128(float128(0.0)));
+#endif // LIBC_TYPES_HAS_FLOAT16
EXPECT_FP_EQ(float128(0.0),
LIBC_NAMESPACE::shared::fromfpf128(float128(0.0), 0, 32));
EXPECT_FP_EQ(float128(0.0),
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 9f9cfa95d2f27..5a52cd532b3ce 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -3350,9 +3350,9 @@ add_fp_unittest(
HDRS
FMinimumNumTest.h
DEPENDS
- libc.src.__support.FPUtil.float128
libc.src.math.fminimum_numf128
libc.src.__support.CPP.algorithm
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.fp_bits
)
diff --git a/libc/test/src/math/smoke/fminimum_numf128_test.cpp b/libc/test/src/math/smoke/fminimum_numf128_test.cpp
index 863e177b06cbe..cc954e817daee 100644
--- a/libc/test/src/math/smoke/fminimum_numf128_test.cpp
+++ b/libc/test/src/math/smoke/fminimum_numf128_test.cpp
@@ -7,8 +7,8 @@
//===----------------------------------------------------------------------===//
#include "FMinimumNumTest.h"
-#include "src/__support/FPUtil/float128.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/fminimum_numf128.h"
#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
>From e2189284711605a04631c8252cbd06a9d91be6ac Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Fri, 4 Sep 2026 13:01:40 +0530
Subject: [PATCH 4/4] order
---
libc/test/shared/shared_math_constexpr_test.cpp | 6 +++---
libc/test/shared/shared_math_test.cpp | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index e3cca0d15a4ea..042fc7d77ae4a 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -395,12 +395,12 @@ static_assert(Float128(0.0) ==
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::fmaximumf128(Float128(0.0),
Float128(0.0)));
-static_assert(Float128(0.0) ==
- LIBC_NAMESPACE::shared::fminimumf128(Float128(0.0),
- Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::fmaximum_numf128(Float128(0.0),
Float128(0.0)));
+static_assert(Float128(0.0) ==
+ LIBC_NAMESPACE::shared::fminimumf128(Float128(0.0),
+ Float128(0.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::fminimum_numf128(Float128(0.0),
Float128(0.0)));
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index f27145ca2ce26..a5fca1342ff31 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -594,10 +594,10 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
LIBC_NAMESPACE::shared::fminf128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximumf128(
Float128(0.0), Float128(0.0)));
- EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminimumf128(
- Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128(
Float128(0.0), Float128(0.0)));
+ EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminimumf128(
+ Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128(
Float128(0.0), Float128(0.0)));
EXPECT_EQ(1, LIBC_NAMESPACE::shared::iscanonicalf128(Float128(0.0)));
More information about the libc-commits
mailing list