[libc-commits] [libc] [libc][cmake] Unify test suite creation and hierarchy in add_libc_testsuite. (PR #234465)

[Pavel Labath via libc-commits]

https://github.com/labath approved this pull request.

I like this a lot. One thing I'd suggest, for the future, is to find a way to separate the boring mechanical changes from the changes in functionality. This makes it easier to review, and also to revert, if necessary.

E.g., in this case, I think the test suite renames could easily be a separate PR. And maybe even the add_custom_target change could be made less intrusively by creating a add_libc_testsuite function, which at first just calls `add_custom_target(name)`.

https://github.com/llvm/llvm-project/pull/234465