[libc-commits] [libc] [libc][cmake] Unify unit and hermetic test rules into add_libc_test (PR #233512)
via libc-commits
libc-commits at lists.llvm.org
Wed Oct 21 14:48:31 PDT 2026
lntue wrote:
> That didn't exactly answer my question -- which more-or-less was: Why is handling MPFR et al. in `add_libc_test` (or some function called by it -- doesn't make a difference) better than having an `add_mpfr_test` wrapper around the other function?
There are few reasons that I want to move handling MPFR et al. in `add_libc_test`:
- To allow tests to combine various traits directly without a combinatorial explosion of wrapper functions or duplicating option handling across wrappers.
- In a later PR, `libc.utils.MPFRWrapper` and `libc.utils.MPCWrapper` will become regular `add_object_library` targets in the dependency graph so most of the special MPFR/MPC check in `create_libc_test` will fold into standard `DEPENDS` resolution.
https://github.com/llvm/llvm-project/pull/233512
More information about the libc-commits
mailing list