[libc-commits] [libc] [llvm] [libc] Moves __cxa_thread_atexit_impl into proper entrypoint (PR #229347)

[Pavel Labath via libc-commits]

labath wrote:

> It seems as though some tests like the : [linux-aarch64-clang](https://github.com/llvm/llvm-project/actions/runs/37581266667/job/112661241424?pr=229347) are failing even when the tests inside it pass?, I'm confused.

If you open that link, you can see that two tests failed to link because of a missing symbol (ld.lld-23: error: undefined symbol: __cxa_thread_atexit_impl). Since this is a regular entrypoint now, you have explicitly have the tests depend on it just like with all other functions. 

Since we now have an actual header that declares the function you can drop the ad-hoc function definition from those tests (just add `LIBC_NAMESPACE::` to the calls).

https://github.com/llvm/llvm-project/pull/229347