[libc-commits] [libc] [llvm] [libc] Moves __cxa_thread_atexit_impl into proper entrypoint (PR #229347)

[Pavel Labath via libc-commits]

https://github.com/labath requested changes to this pull request.

Please make sure to resolve the issues with the automated premerge checks. For the format check, running the patch over clang-format should suffice. The double_exit_test most likely fails because you now need to add the new entry point to the list of dependencies for the test.

> I'm not aware of what nature of tests I should be implementing, could you elaborate me on that?

You want to test that the function does what it's supposed to do -- that it calls the correct callback, with the correct argument, in the correct order. I think you could do something similar to double_exit_test.cpp, except that you check other properties instead of double calls.

https://github.com/llvm/llvm-project/pull/229347