[libc-commits] [libc] [libc] Implement killpg (PR #237561)

Alexey Samsonov via libc-commits libc-commits at lists.llvm.org
Sun Nov 1 08:59:10 PST 2026


vonosmas wrote:

> Thanks for the review @vonosmas! I've addressed all the feedback: updated to modern \file headers, decoupled killpg to invoke SYS_kill directly, restored CMake whitespace, and split the tests using getpgrp().

Thank you for the updates. However, I explicitly mentioned that `kill` syscall usage should instead be refactored
according to the https://libc.llvm.org/dev/syscall_wrapper_refactor.html#syscall-wrapper-refactoring  in a separate
PR, but instead you invoked this syscall directly here, from `killpg` implementation.


https://github.com/llvm/llvm-project/pull/237561


More information about the libc-commits mailing list