[libc-commits] [libc] [libc] Remove 32-bit time_t support (PR #200426)

Mikhail R. Gadelha via libc-commits libc-commits at lists.llvm.org
Sat May 30 09:55:34 PDT 2026


https://github.com/mikhailramalho approved this pull request.

I tested locally, and it only needs the following changes:
```
diff --git a/libc/test/src/__support/time/linux/timeout_test.cpp b/libc/test/src/__support/time/linux/timeout_test.cpp
index 33e823195992..8a59312f4352 100644
--- a/libc/test/src/__support/time/linux/timeout_test.cpp
+++ b/libc/test/src/__support/time/linux/timeout_test.cpp
@@ -45,7 +45,8 @@ TEST(LlvmLibcSupportLinuxTimeoutTest, NoChangeIfClockIsMonotonic) {
   ensure_monotonicity(*result);
   ASSERT_FALSE(result->is_realtime());
   ASSERT_EQ(result->get_timespec().tv_sec, static_cast<time_t>(10000));
-  ASSERT_EQ(result->get_timespec().tv_nsec, static_cast<long int>(0));
+  ASSERT_EQ(result->get_timespec().tv_nsec,
+            static_cast<decltype(result->get_timespec().tv_nsec)>(0));
 }
 TEST(LlvmLibcSupportLinuxTimeoutTest, ValidAfterConversion) {
   timespec ts;
diff --git a/libc/test/src/sys/time/utimes_test.cpp b/libc/test/src/sys/time/utimes_test.cpp
index 3c8688ebda8d..0bb67a5044a0 100644
--- a/libc/test/src/sys/time/utimes_test.cpp
+++ b/libc/test/src/sys/time/utimes_test.cpp
@@ -54,9 +54,11 @@ TEST_F(LlvmLibcUtimesTest, ChangeTimesSpecific) {

   // microseconds
   ASSERT_EQ(statbuf.st_atim.tv_nsec,
-            static_cast<long>(times[0].tv_usec * 1000));
+            static_cast<decltype(statbuf.st_atim.tv_nsec)>(times[0].tv_usec *
+                                                           1000));
   ASSERT_EQ(statbuf.st_mtim.tv_nsec,
-            static_cast<long>(times[1].tv_usec * 1000));
+            static_cast<decltype(statbuf.st_mtim.tv_nsec)>(times[1].tv_usec *
+                                                           1000));

   // legacy way to check seconds
   ASSERT_EQ(statbuf.st_atime, times[0].tv_sec);

https://github.com/llvm/llvm-project/pull/200426


More information about the libc-commits mailing list