[libc-commits] [libc] [libc] Add a differential fuzzer for inet_aton (PR #200341)

[via libc-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Pavel Labath (labath)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/200341.diff


4 Files Affected:

- (modified) libc/fuzzing/CMakeLists.txt (+1) 
- (added) libc/fuzzing/arpa/CMakeLists.txt (+1) 
- (added) libc/fuzzing/arpa/inet/CMakeLists.txt (+7) 
- (added) libc/fuzzing/arpa/inet/inet_aton_differential_fuzz.cpp (+46) 


``````````diff
diff --git a/libc/fuzzing/CMakeLists.txt b/libc/fuzzing/CMakeLists.txt
index e2dcecca7f7df..de3ae527b495a 100644
--- a/libc/fuzzing/CMakeLists.txt
+++ b/libc/fuzzing/CMakeLists.txt
@@ -2,6 +2,7 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=fuzzer")
 add_custom_target(libc-fuzzer)
 
 add_subdirectory(__support)
+add_subdirectory(arpa)
 # TODO(#85680): Re-enable math fuzzing after headers are sorted out
 add_subdirectory(math)
 add_subdirectory(stdlib)
diff --git a/libc/fuzzing/arpa/CMakeLists.txt b/libc/fuzzing/arpa/CMakeLists.txt
new file mode 100644
index 0000000000000..5c89828860ff8
--- /dev/null
+++ b/libc/fuzzing/arpa/CMakeLists.txt
@@ -0,0 +1 @@
+add_subdirectory(inet)
diff --git a/libc/fuzzing/arpa/inet/CMakeLists.txt b/libc/fuzzing/arpa/inet/CMakeLists.txt
new file mode 100644
index 0000000000000..a2083133682ff
--- /dev/null
+++ b/libc/fuzzing/arpa/inet/CMakeLists.txt
@@ -0,0 +1,7 @@
+add_libc_fuzzer(
+  inet_aton_differential_fuzz
+  SRCS
+    inet_aton_differential_fuzz.cpp
+  DEPENDS
+    libc.src.arpa.inet.inet_aton
+)
diff --git a/libc/fuzzing/arpa/inet/inet_aton_differential_fuzz.cpp b/libc/fuzzing/arpa/inet/inet_aton_differential_fuzz.cpp
new file mode 100644
index 0000000000000..e202f96c4c120
--- /dev/null
+++ b/libc/fuzzing/arpa/inet/inet_aton_differential_fuzz.cpp
@@ -0,0 +1,46 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+///
+/// \file
+/// Differential fuzz test for llvm-libc inet_aton implementation.
+///
+//===----------------------------------------------------------------------===//
+
+#include "src/arpa/inet/inet_aton.h"
+#include <arpa/inet.h>
+#include <stddef.h>
+#include <stdint.h>
+#include <stdio.h>
+
+extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
+  if (size == 0 || data[size - 1] != '\0')
+    return -1;
+
+  struct in_addr ref_addr = {};
+  struct in_addr impl_addr = {};
+  int ref = ::inet_aton(reinterpret_cast<const char *>(data), &ref_addr);
+  int impl = LIBC_NAMESPACE::inet_aton(reinterpret_cast<const char *>(data),
+                                       &impl_addr);
+
+  if (ref != impl) {
+    fprintf(stderr,
+            "Different result (reference: %d, implementation: %d) for \"%s\"\n",
+            ref, impl, data);
+    __builtin_trap();
+  }
+
+  if (ref == 1 && ref_addr.s_addr != impl_addr.s_addr) {
+    fprintf(
+        stderr,
+        "Different address (reference: %x, implementation: %x) for \"%s\"\n",
+        ref_addr.s_addr, impl_addr.s_addr, data);
+    __builtin_trap();
+  }
+
+  return 0;
+}

``````````

</details>


https://github.com/llvm/llvm-project/pull/200341