[libc-commits] [clang] [libc] [libcxx] [clang][X86] Emit AVX level mismatch psABI warnings on function definitions (PR #199091)

[Benjamin Luke via libc-commits]

================
@@ -75,6 +75,8 @@
 
     # We're not annotating all the APIs, since that's a lot of annotations compared to how many we actually care about
     "-Wno-nullability-completeness",
+    # Adding this for now to get the build to pass but needs more detailed review
+    "-Wno-psabi",
----------------
freaknbigpanda wrote:

OK I think I found a pretty good solution, I am now guarding the emission of these warnings with: 
```
// psABI warnings & errors for function definitions that are only visible 
// in this translation unit are handled at call site by checkFunctionCallABI
if (!FD->isExternallyVisible())
  return;
```
Which fixes everything for libc, for libcxx there were already pragmas in the offending file so I expanded those to include the additional functions 

https://github.com/llvm/llvm-project/pull/199091