[libc-commits] [libc] ae8d973 - Fix unused parameter for add_bitcode_entrypoint_library for GPU Libc (#198458)

via libc-commits libc-commits at lists.llvm.org
Tue May 19 06:43:35 PDT 2026


Author: jinge90
Date: 2026-05-19T21:43:29+08:00
New Revision: ae8d973ae253463e4b821086b720fbc813c61e96

URL: https://github.com/llvm/llvm-project/commit/ae8d973ae253463e4b821086b720fbc813c61e96
DIFF: https://github.com/llvm/llvm-project/commit/ae8d973ae253463e4b821086b720fbc813c61e96.diff

LOG: Fix unused parameter for add_bitcode_entrypoint_library for GPU Libc (#198458)

Added: 
    

Modified: 
    libc/cmake/modules/LLVMLibCLibraryRules.cmake

Removed: 
    


################################################################################
diff  --git a/libc/cmake/modules/LLVMLibCLibraryRules.cmake b/libc/cmake/modules/LLVMLibCLibraryRules.cmake
index 9f8c6c0db8c6f..2df8f49100b99 100644
--- a/libc/cmake/modules/LLVMLibCLibraryRules.cmake
+++ b/libc/cmake/modules/LLVMLibCLibraryRules.cmake
@@ -83,7 +83,7 @@ endfunction()
 # A rule to build a library from a collection of entrypoint objects and bundle
 # it in a single LLVM-IR bitcode file.
 # Usage:
-#     add_gpu_entrypoint_library(
+#     add_bitcode_entrypoint_library(
 #       DEPENDS <list of add_entrypoint_object targets>
 #     )
 function(add_bitcode_entrypoint_library target_name base_target_name)
@@ -116,6 +116,7 @@ function(add_bitcode_entrypoint_library target_name base_target_name)
       target_link_options(${target_name} PRIVATE "${LIBC_COMPILE_OPTIONS_DEFAULT}"
                       "-r" "-nostdlib" "-flto" "-Wl,--lto-emit-llvm")
   endif()
+  add_dependencies(${base_target_name} ${target_name})
 endfunction(add_bitcode_entrypoint_library)
 
 # A rule to build a library from a collection of entrypoint objects.


        


More information about the libc-commits mailing list