[libc-commits] [clang-tools-extra] [libc] [llvm] [Github][CI] Don't build analysis targets when no relevant projects present (PR #196882)
Baranov Victor via libc-commits
libc-commits at lists.llvm.org
Sun May 10 23:09:08 PDT 2026
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/196882
>From fd08aec94e7ebe30c65f2fc0df5d1d5d513f4f62 Mon Sep 17 00:00:00 2001
From: Victor Baranov <bar.victor.2002 at gmail.com>
Date: Mon, 11 May 2026 08:59:58 +0300
Subject: [PATCH 1/3] [Github][CI] Don't build analysis targets when no
relevant projects are present
---
.github/workflows/pr-code-lint.yml | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/pr-code-lint.yml b/.github/workflows/pr-code-lint.yml
index 829a1ec5b94ca..5101db3ca7612 100644
--- a/.github/workflows/pr-code-lint.yml
+++ b/.github/workflows/pr-code-lint.yml
@@ -74,9 +74,16 @@ jobs:
-DCLANG_INCLUDE_TESTS=OFF \
-DCMAKE_BUILD_TYPE=Release
- ninja -C build \
- clang-tablegen-targets \
- genconfusable # for "ConfusableIdentifierCheck.h"
+ ninja_targets=""
+ if [[ ";${projects_to_build};" == *";clang;"* ]]; then
+ ninja_targets="${ninja_targets} clang-tablegen-targets"
+ fi
+ if [[ ";${projects_to_build};" == *";clang-tools-extra;"* ]]; then
+ ninja_targets="${ninja_targets} genconfusable"
+ fi
+ if [[ -n "${ninja_targets}" ]]; then
+ ninja -C build ${ninja_targets}
+ fi
- name: Run code linters
env:
>From d60d69991564354b98246c92128796fef9f8e33b Mon Sep 17 00:00:00 2001
From: Victor Baranov <bar.victor.2002 at gmail.com>
Date: Mon, 11 May 2026 09:01:50 +0300
Subject: [PATCH 2/3] test changes
---
.../clang-tidy/checks/llvmlibc/implementation-in-namespace.rst | 2 +-
libc/docs/conf.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/clang-tools-extra/docs/clang-tidy/checks/llvmlibc/implementation-in-namespace.rst b/clang-tools-extra/docs/clang-tidy/checks/llvmlibc/implementation-in-namespace.rst
index a00e476e06438..84774881fbbcc 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/llvmlibc/implementation-in-namespace.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/llvmlibc/implementation-in-namespace.rst
@@ -10,7 +10,7 @@ correct namespace.
// Implementation inside the LIBC_NAMESPACE_DECL namespace.
// Correct if:
- // - LIBC_NAMESPACE_DECL is a macro
+ // Some change - LIBC_NAMESPACE_DECL is a macro
// - LIBC_NAMESPACE_DECL expansion starts with `[[gnu::visibility("hidden")]] __llvm_libc`
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(char *, strcpy, (char *dest, const char *src)) {}
diff --git a/libc/docs/conf.py b/libc/docs/conf.py
index 4608a0282c24c..e3de2044d4119 100644
--- a/libc/docs/conf.py
+++ b/libc/docs/conf.py
@@ -90,7 +90,7 @@
# If true, sectionauthor and moduleauthor directives will be shown in the
# output. They are ignored by default.
-show_authors = True
+show_authors = True
# The name of the Pygments (syntax highlighting) style to use.
pygments_style = "friendly"
>From 40f8c11a1e5da896b8df4dd79471bc1158cdd4a5 Mon Sep 17 00:00:00 2001
From: Victor Baranov <bar.victor.2002 at gmail.com>
Date: Mon, 11 May 2026 09:08:53 +0300
Subject: [PATCH 3/3] test changes 2
---
libc/src/string/memchr.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libc/src/string/memchr.cpp b/libc/src/string/memchr.cpp
index ccdc262837cd4..7056cfdacd632 100644
--- a/libc/src/string/memchr.cpp
+++ b/libc/src/string/memchr.cpp
@@ -20,7 +20,7 @@ namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(void *, memchr, (const void *src, int c, size_t n)) {
if (n)
LIBC_CRASH_ON_NULLPTR(src);
- return internal::find_first_character(
+ return internal::find_first_character(
reinterpret_cast<const unsigned char *>(src),
static_cast<unsigned char>(c), n);
}
More information about the libc-commits
mailing list