[libc-commits] [libc] Revert "[libc] Build with -Wshadow" (PR #197201)

Nico Weber via libc-commits libc-commits at lists.llvm.org
Tue May 12 06:58:09 PDT 2026


https://github.com/nico created https://github.com/llvm/llvm-project/pull/197201

Reverts llvm/llvm-project#196519

Passed CI on the PR, but apparently breaks several bots.

>From 34acca2450223eb6f822ec957e5c1bf8875961e0 Mon Sep 17 00:00:00 2001
From: Nico Weber <thakis at chromium.org>
Date: Tue, 12 May 2026 09:57:38 -0400
Subject: [PATCH] Revert "[libc] Build with -Wshadow (#196519)"

This reverts commit 6d4f4642d978debd4c4a4057361a0a0f42de5743.
---
 libc/cmake/modules/LLVMLibCCompileOptionRules.cmake | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake b/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake
index db541a4dfb985..2d3703eefa0ac 100644
--- a/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake
+++ b/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake
@@ -301,7 +301,6 @@ function(_get_common_compile_options output_var flags)
     if(NOT CMAKE_COMPILER_IS_GNUCXX)
       list(APPEND compile_options "-Wnewline-eof")
       list(APPEND compile_options "-Wnonportable-system-include-path")
-      list(APPEND compile_options "-Wshadow")
       list(APPEND compile_options "-Wstrict-prototypes")
       list(APPEND compile_options "-Wthread-safety")
       list(APPEND compile_options "-Wglobal-constructors")



More information about the libc-commits mailing list