[libc-commits] [libc] [libc] Add some types to netinet/in.h (PR #196932)

[Pavel Labath via libc-commits]

labath wrote:

> That's exactly why glibc does that - so that they're not leaking extra types in. It also means that if you suddenly change a header, you're not breaking people's code with a libc upgrade because they were expecting a transative dependency.

I get that -- it's just not how it's working right now (no `__uint32_t_defined` anywhere to be found). I took a closer look, and it looks like now it just puts the `uint{8,16,32,64}_t` typedefs into a separate header (bits/stdint-uintn.h) and uses regular header guards to protect that (i.e. similar to what we do as well).

> lgtm for now, I'll file a bug to audit stdint leaking into headers as you're right, it happens in other places too.

SG. If you give me some sort of a guideline on what to do (e.g. "do the glibc thing"), I'd be happy to implement it.

https://github.com/llvm/llvm-project/pull/196932