[libc-commits] [libc] [libc] Fix -Wshadow warning in sqrtf128.h (PR #196851)

Nico Weber via libc-commits libc-commits at lists.llvm.org
Sun May 10 17:36:51 PDT 2026


https://github.com/nico created https://github.com/llvm/llvm-project/pull/196851

sqrtf128() contained both `using namespace sqrtf128_internal;` and `using FPBits = fputil::FPBits<float128>;`, but sqrtf128_internal also had a `using FPBits = fputil::FPBits<float128>;`. The outer `using` wasn't actually used, so remove that one.

>From a3034f8f1be9bb5797ffdca80c5f42fca7749278 Mon Sep 17 00:00:00 2001
From: Nico Weber <thakis at chromium.org>
Date: Sun, 10 May 2026 17:49:14 -0400
Subject: [PATCH] [libc] Fix -Wshadow warning in sqrtf128.h

sqrtf128() contained both `using namespace sqrtf128_internal;`
and `using FPBits = fputil::FPBits<float128>;`, but sqrtf128_internal
also had a `using FPBits = fputil::FPBits<float128>;`. The outer
`using` wasn't actually used, so remove that one.
---
 libc/src/__support/math/sqrtf128.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libc/src/__support/math/sqrtf128.h b/libc/src/__support/math/sqrtf128.h
index d5b54b724c259..14dcbec1acbb6 100644
--- a/libc/src/__support/math/sqrtf128.h
+++ b/libc/src/__support/math/sqrtf128.h
@@ -60,8 +60,6 @@ namespace math {
 
 namespace sqrtf128_internal {
 
-using FPBits = fputil::FPBits<float128>;
-
 template <typename T, typename U = T> LIBC_INLINE constexpr T prod_hi(T, U);
 
 // Get high part of integer multiplications.



More information about the libc-commits mailing list