[libc-commits] [libc] [libc] Create socketcall helper for Linux syscall wrappers (PR #196903)

[Jeff Bailey via libc-commits]

kaladron wrote:

> > I like the simplification you're working on here! Are the sites I flagged being called at all? They look like they shouldn't compile.
> 
> Well.. that is embarrassing. 

I'm sorry!  I didn't mean that to be!  Me doing something like this is part of why I want to get back to getting the coverage stuff going so that it's easy to tell at a glance.  Especially with all the #ifdefs, it's an easy mistake to make.

> I checked that the wrapper code is actually built, but it did not occur to me to check whether the call sites were being build (which they were not because my system defines both SYS_whatever _and_ the SYS_socketcall syscall numbers (I guess older systems would only define SYS_socketcall).
> 
> The new versions fixes those errors, and I've now checked (by manually changing the chosen preprocessor branch) that code builds and passes tests.

Thank you!



https://github.com/llvm/llvm-project/pull/196903