[libc-commits] [libc] [libc] Fix partial multi-byte write detection in File (PR #196402)

[via libc-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>libc/test/src/__support/File/CMakeFiles/libc.test.src.__support.File.file_test.__unit__.__build__.dir/file_test.cpp.o</summary>

```
FAILED: libc/test/src/__support/File/CMakeFiles/libc.test.src.__support.File.file_test.__unit__.__build__.dir/file_test.cpp.o
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -DLIBC_NAMESPACE=__llvm_libc_23_0_0_git -I/home/gha/actions-runner/_work/llvm-project/llvm-project/libc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/runtimes/runtimes-bins/libc -isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/runtimes/runtimes-bins/libc/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Xclang -fno-pch-timestamp -O3 -DNDEBUG -std=gnu++17 -UNDEBUG -D__LIBC_USE_BUILTIN_ISNAN -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_COPT_STRING_LENGTH_IMPL=clang_vector -DLIBC_COPT_FIND_FIRST_CHARACTER_IMPL=word -DLIBC_ADD_NULL_CHECKS -DLIBC_ERRNO_MODE=LIBC_ERRNO_MODE_DEFAULT -DLIBC_THREAD_MODE=LIBC_THREAD_MODE_PLATFORM -DLIBC_COPT_TIMEOUT_ENSURE_MONOTONICITY -DLIBC_CONF_WCTYPE_MODE=LIBC_WCTYPE_MODE_ASCII -DLIBC_COPT_RAW_MUTEX_DEFAULT_SPIN_COUNT=100 -fpie -ffixed-point -Wall -Wextra -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wstrict-prototypes -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wthread-safety -DLIBC_TEST=UNIT -MD -MT libc/test/src/__support/File/CMakeFiles/libc.test.src.__support.File.file_test.__unit__.__build__.dir/file_test.cpp.o -MF libc/test/src/__support/File/CMakeFiles/libc.test.src.__support.File.file_test.__unit__.__build__.dir/file_test.cpp.o.d -o libc/test/src/__support/File/CMakeFiles/libc.test.src.__support.File.file_test.__unit__.__build__.dir/file_test.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/src/__support/File/file_test.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/src/__support/File/file_test.cpp:854:3: error: no matching member function for call to 'test'
854 |   EXPECT_LT(result.value, 1);
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/UnitTest/LibcTest.h:448:29: note: expanded from macro 'EXPECT_LT'
448 | #define EXPECT_LT(LHS, RHS) LIBC_TEST_BINOP_(LT, LHS, RHS, )
|                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/UnitTest/LibcTest.h:435:26: note: expanded from macro 'LIBC_TEST_BINOP_'
435 |   LIBC_TEST_SCAFFOLDING_(test(LIBC_NAMESPACE::testing::TestCond::COND, LHS,    \
|                          ^~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/UnitTest/LibcTest.h:145:8: note: candidate template ignored: deduced conflicting types for parameter 'ValType' ('size_t' (aka 'unsigned long') vs. 'int')
145 |   bool test(TestCond Cond, ValType LHS, ValType RHS, const char *LHSStr,
|        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/UnitTest/LibcTest.h:152:8: note: candidate template ignored: deduced conflicting types for parameter 'ValType' ('size_t' (aka 'unsigned long') vs. 'int')
152 |   bool test(TestCond Cond, ValType LHS, ValType RHS, const char *LHSStr,
|        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/UnitTest/LibcTest.h:160:8: note: candidate template ignored: deduced conflicting types for parameter 'ValType' ('size_t' (aka 'unsigned long') vs. 'int')
160 |   bool test(TestCond Cond, ValType LHS, ValType RHS, const char *LHSStr,
|        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/UnitTest/LibcTest.h:178:8: note: candidate template ignored: deduced conflicting types for parameter 'ValType' ('size_t' (aka 'unsigned long') vs. 'int')
178 |   bool test(TestCond Cond, ValType LHS, ValType RHS, const char *LHSStr,
|        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/UnitTest/LibcTest.h:186:8: note: candidate template ignored: deduced conflicting types for parameter 'ValType' ('size_t' (aka 'unsigned long') vs. 'int')
186 |   bool test(TestCond Cond, ValType LHS, ValType RHS, const char *LHSStr,
|        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/UnitTest/LibcTest.h:169:8: note: candidate template ignored: substitution failure [with ValType = size_t]: implicit instantiation of undefined template '__llvm_libc_23_0_0_git::cpp::enable_if<false, unsigned long>'
169 |   bool test(TestCond Cond, ValType LHS, cpp::nullptr_t, const char *LHSStr,
|        ^
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/196402