[libc-commits] [libc] [libc][math] Fix a -Wshadow warning in add_sub.h (PR #196337)

[via libc-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Nico Weber (nico)

<details>
<summary>Changes</summary>

y_bits on line 111 was shadowing y_bits on line 48.

No behavior change.

---
Full diff: https://github.com/llvm/llvm-project/pull/196337.diff


1 Files Affected:

- (modified) libc/src/__support/FPUtil/generic/add_sub.h (+3-3) 


``````````diff
diff --git a/libc/src/__support/FPUtil/generic/add_sub.h b/libc/src/__support/FPUtil/generic/add_sub.h
index 6db5bcbb75020..a7f22865a6a00 100644
--- a/libc/src/__support/FPUtil/generic/add_sub.h
+++ b/libc/src/__support/FPUtil/generic/add_sub.h
@@ -108,10 +108,10 @@ add_or_sub(InType x, InType y) {
 
       if constexpr (cpp::is_same_v<InType, bfloat16> &&
                     cpp::is_same_v<OutType, bfloat16>) {
-        OutFPBits y_bits(y);
+        OutFPBits out_y_bits(y);
         if constexpr (IsSub)
-          y_bits.set_sign(y_bits.sign().negate());
-        return y_bits.get_val();
+          out_y_bits.set_sign(out_y_bits.sign().negate());
+        return out_y_bits.get_val();
       } else {
 
 #ifdef LIBC_HAS_CONSTANT_EVALUATION

``````````

</details>


https://github.com/llvm/llvm-project/pull/196337