[libc-commits] [libc] [llvm] [libc][math] Refactor lrint_lround family to header-only (PR #195441)

[via libc-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>libc/src/math/generic/CMakeFiles/libc.src.math.generic.lroundl.dir/lroundl.cpp.o</summary>

```
FAILED: libc/src/math/generic/CMakeFiles/libc.src.math.generic.lroundl.dir/lroundl.cpp.o
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -DLIBC_NAMESPACE=__llvm_libc_23_0_0_git -I/home/gha/actions-runner/_work/llvm-project/llvm-project/libc -isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/runtimes/runtimes-bins/libc/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Xclang -fno-pch-timestamp -O3 -DNDEBUG -std=gnu++17 -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_COPT_STRING_LENGTH_IMPL=clang_vector -DLIBC_COPT_FIND_FIRST_CHARACTER_IMPL=word -DLIBC_ADD_NULL_CHECKS -DLIBC_ERRNO_MODE=LIBC_ERRNO_MODE_DEFAULT -DLIBC_THREAD_MODE=LIBC_THREAD_MODE_PLATFORM -DLIBC_COPT_TIMEOUT_ENSURE_MONOTONICITY -DLIBC_CONF_WCTYPE_MODE=LIBC_WCTYPE_MODE_ASCII -DLIBC_COPT_RAW_MUTEX_DEFAULT_SPIN_COUNT=100 -fpie -ffixed-point -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fstack-protector-strong -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wdeprecated -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -MD -MT libc/src/math/generic/CMakeFiles/libc.src.math.generic.lroundl.dir/lroundl.cpp.o -MF libc/src/math/generic/CMakeFiles/libc.src.math.generic.lroundl.dir/lroundl.cpp.o.d -o libc/src/math/generic/CMakeFiles/libc.src.math.generic.lroundl.dir/lroundl.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/libc/src/math/generic/lroundl.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/src/math/generic/lroundl.cpp:14:1: error: definition with same mangled name 'lroundl' as another definition
14 | LLVM_LIBC_FUNCTION(long, lroundl, (long double x)) { return math::lroundl(x); }
| ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/src/__support/common.h:78:53: note: expanded from macro 'LLVM_LIBC_FUNCTION'
78 |   GET_FIFTH(__VA_ARGS__, LLVM_LIBC_FUNCTION_IMPL_4, LLVM_LIBC_FUNCTION_IMPL_3, \
|                                                     ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/src/__support/math/lroundl.h:18:1: note: previous definition is here
18 | LLVM_LIBC_FUNCTION(long, lroundl, (long double x)) {
| ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/src/__support/common.h:78:53: note: expanded from macro 'LLVM_LIBC_FUNCTION'
78 |   GET_FIFTH(__VA_ARGS__, LLVM_LIBC_FUNCTION_IMPL_4, LLVM_LIBC_FUNCTION_IMPL_3, \
|                                                     ^
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/195441