[libc-commits] [libc] 6b2e347 - [libc]: implement 'iswpunct' entrypoint (#186968)
via libc-commits
libc-commits at lists.llvm.org
Tue Mar 17 12:53:09 PDT 2026
Author: kubikusik
Date: 2026-03-17T12:53:03-07:00
New Revision: 6b2e347ae12b35780e69477ce3c1704bc4f91fad
URL: https://github.com/llvm/llvm-project/commit/6b2e347ae12b35780e69477ce3c1704bc4f91fad
DIFF: https://github.com/llvm/llvm-project/commit/6b2e347ae12b35780e69477ce3c1704bc4f91fad.diff
LOG: [libc]: implement 'iswpunct' entrypoint (#186968)
Added entrypoints:
- baremetal/arm
- baremetal/aarch64
- baremetal/riscv
- darwin/aarch64
- linux/aarch64
- linux/arm
- linux/riscv
- linux/x86_64
- windows
Also added the unit test for iswpunct.
Part of the issue: #185136
Added:
libc/src/wctype/iswpunct.cpp
libc/src/wctype/iswpunct.h
libc/test/src/wctype/iswpunct_test.cpp
Modified:
libc/config/baremetal/aarch64/entrypoints.txt
libc/config/baremetal/arm/entrypoints.txt
libc/config/baremetal/riscv/entrypoints.txt
libc/config/darwin/aarch64/entrypoints.txt
libc/config/linux/aarch64/entrypoints.txt
libc/config/linux/arm/entrypoints.txt
libc/config/linux/riscv/entrypoints.txt
libc/config/linux/x86_64/entrypoints.txt
libc/config/windows/entrypoints.txt
libc/include/wctype.yaml
libc/src/wctype/CMakeLists.txt
libc/test/src/wctype/CMakeLists.txt
Removed:
################################################################################
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index c4e040e537cd0..9fa9744cf109d 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -300,6 +300,9 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.wchar.wcslen
libc.src.wchar.wctob
+ # wctype.h entrypoints
+ libc.src.wctype.iswpunct
+
# internal entrypoints
libc.startup.baremetal.init
libc.startup.baremetal.fini
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index 7acaca15d39ae..83717616e3135 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -311,6 +311,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.wctype.iswspace
libc.src.wctype.iswblank
libc.src.wctype.iswxdigit
+ libc.src.wctype.iswpunct
# internal entrypoints
libc.startup.baremetal.init
libc.startup.baremetal.fini
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index fc6201b44149f..3c922062d2f8b 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -308,6 +308,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.wctype.iswspace
libc.src.wctype.iswblank
libc.src.wctype.iswxdigit
+ libc.src.wctype.iswpunct
# internal entrypoints
libc.startup.baremetal.init
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index 2d26763e29d03..11f142266d9a9 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -111,6 +111,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.wctype.iswspace
libc.src.wctype.iswblank
libc.src.wctype.iswxdigit
+ libc.src.wctype.iswpunct
)
if(LLVM_LIBC_FULL_BUILD)
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 380c91e1ac396..92cf42a296264 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -382,6 +382,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.wctype.iswspace
libc.src.wctype.iswblank
libc.src.wctype.iswxdigit
+ libc.src.wctype.iswpunct
# sys/uio.h entrypoints
libc.src.sys.uio.writev
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 8611082f87003..737d6fcc6016a 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -203,6 +203,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.wctype.iswspace
libc.src.wctype.iswblank
libc.src.wctype.iswxdigit
+ libc.src.wctype.iswpunct
)
if(LLVM_LIBC_FULL_BUILD)
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index ddb24c3eea178..312329895e081 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -386,6 +386,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.wctype.iswspace
libc.src.wctype.iswblank
libc.src.wctype.iswxdigit
+ libc.src.wctype.iswpunct
# sys/uio.h entrypoints
libc.src.sys.uio.writev
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 9102de9bf0417..1039c28eb5c6f 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -431,6 +431,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.wctype.iswspace
libc.src.wctype.iswblank
libc.src.wctype.iswxdigit
+ libc.src.wctype.iswpunct
# sys/uio.h entrypoints
libc.src.sys.uio.writev
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index 02b56ab01081b..089cd1c8ede89 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -117,6 +117,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.wctype.iswspace
libc.src.wctype.iswblank
libc.src.wctype.iswxdigit
+ libc.src.wctype.iswpunct
)
set(TARGET_LIBM_ENTRYPOINTS
diff --git a/libc/include/wctype.yaml b/libc/include/wctype.yaml
index ca47cae27b640..170eac48e734a 100644
--- a/libc/include/wctype.yaml
+++ b/libc/include/wctype.yaml
@@ -62,3 +62,9 @@ functions:
return_type: int
arguments:
- type: wint_t
+ - name: iswpunct
+ standards:
+ - stdc
+ return_type: int
+ arguments:
+ - type: wint_t
diff --git a/libc/src/wctype/CMakeLists.txt b/libc/src/wctype/CMakeLists.txt
index 73ec0eb9c857f..d22d21eb487f9 100644
--- a/libc/src/wctype/CMakeLists.txt
+++ b/libc/src/wctype/CMakeLists.txt
@@ -107,3 +107,15 @@ add_entrypoint_object(
libc.hdr.types.wint_t
libc.src.__support.wctype_utils
)
+
+add_entrypoint_object(
+ iswpunct
+ SRCS
+ iswpunct.cpp
+ HDRS
+ iswpunct.h
+ DEPENDS
+ libc.src.__support.common
+ libc.src.__support.wctype_utils
+ libc.hdr.types.wint_t
+)
diff --git a/libc/src/wctype/iswpunct.cpp b/libc/src/wctype/iswpunct.cpp
new file mode 100644
index 0000000000000..d02bbbb2ed00a
--- /dev/null
+++ b/libc/src/wctype/iswpunct.cpp
@@ -0,0 +1,19 @@
+//===-- Implementation of iswpunct ----------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/wctype/iswpunct.h"
+#include "src/__support/common.h"
+#include "src/__support/wctype_utils.h"
+
+#include "hdr/types/wint_t.h"
+
+namespace LIBC_NAMESPACE_DECL {
+LLVM_LIBC_FUNCTION(int, iswpunct, (wint_t c)) {
+ return internal::ispunct(static_cast<wchar_t>(c));
+}
+} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/wctype/iswpunct.h b/libc/src/wctype/iswpunct.h
new file mode 100644
index 0000000000000..28fd7c37ab9c0
--- /dev/null
+++ b/libc/src/wctype/iswpunct.h
@@ -0,0 +1,21 @@
+//===-- Implementation header for iswpunct ----------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_WCTYPE_ISWPUNCT_H
+#define LLVM_LIBC_SRC_WCTYPE_ISWPUNCT_H
+
+#include "hdr/types/wint_t.h"
+#include "src/__support/common.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+int iswpunct(wint_t c);
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC_WCTYPE_ISWPUNCT_H
diff --git a/libc/test/src/wctype/CMakeLists.txt b/libc/test/src/wctype/CMakeLists.txt
index 65189a0d16d5a..132d74daaac70 100644
--- a/libc/test/src/wctype/CMakeLists.txt
+++ b/libc/test/src/wctype/CMakeLists.txt
@@ -101,3 +101,13 @@ add_libc_test(
DEPENDS
libc.src.wctype.iswupper
)
+
+add_libc_test(
+ iswpunct_test
+ SUITE
+ libc_wctype_unittests
+ SRCS
+ iswpunct_test.cpp
+ DEPENDS
+ libc.src.wctype.iswpunct
+)
diff --git a/libc/test/src/wctype/iswpunct_test.cpp b/libc/test/src/wctype/iswpunct_test.cpp
new file mode 100644
index 0000000000000..03c9249d64282
--- /dev/null
+++ b/libc/test/src/wctype/iswpunct_test.cpp
@@ -0,0 +1,63 @@
+//===-- Unittests for iswpunct --------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/wctype/iswpunct.h"
+
+#include "test/UnitTest/Test.h"
+
+TEST(LlvmLibciswpunct, SimpleTest) {
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('!'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('\"'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('#'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('$'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('%'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('&'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('\''), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('('), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct(')'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('*'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('+'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct(','), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('-'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('.'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('/'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct(':'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct(';'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('<'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('='), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('>'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('?'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('@'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('['), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('\\'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct(']'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('^'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('_'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('`'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('{'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('|'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('}'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswpunct('~'), 0);
+
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('\n'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('\v'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('\f'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('\r'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('\0'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('\t'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct(' '), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('0'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('5'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('9'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('A'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('M'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('Z'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('a'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('m'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswpunct('z'), 0);
+}
More information about the libc-commits
mailing list