[libc-commits] [libc] [libc] Use the proper name for the 'llvm-gpu-loader' (PR #186101)

[Joel E. Denny via libc-commits]

jdenny-ornl wrote:

Starting at this commit, I see 663 failed libc tests under `check-all`.  I configured using `offload/cmake/caches/Offload.cmake`.  `LIT_FILTER=libc ninja check-all` reproduces without having to run all of `check-all`.

The error is:

```
llvm-gpu-loader: Not enough positional command line arguments specified!
```

The following works around that problem by avoiding premature expansion of `@BINARY@`:

```
diff --git a/libc/test/lit.site.cfg.py.in b/libc/test/lit.site.cfg.py.in
index 7773bdfdf0e9..3bcc585bbb2e 100644
--- a/libc/test/lit.site.cfg.py.in
+++ b/libc/test/lit.site.cfg.py.in
@@ -12,7 +12,7 @@ config.libc_gpu_loader = path(r"@LIBC_GPU_LOADER_EXECUTABLE@")
 
 # If running GPU tests and no explicit test command is set, use the GPU loader.
 if not config.libc_test_cmd and config.libc_gpu_loader:
-    config.libc_test_cmd = config.libc_gpu_loader + " @BINARY@"
+    config.libc_test_cmd = config.libc_gpu_loader + " @" + "BINARY@"
 
 # Add libc's utils directory to the path so we can import the test format.
 site.addsitedir(os.path.join(config.libc_src_root, "utils"))
```

I am not confident that is the best fix, but hopefully it at least helps clarify the problem.

https://github.com/llvm/llvm-project/pull/186101