[libc-commits] [libc] 4f76d16 - [libc] Implement iswgraph entrypoint (#185339)
via libc-commits
libc-commits at lists.llvm.org
Wed Mar 11 08:04:42 PDT 2026
Author: Xinlong Chen
Date: 2026-03-11T08:04:37-07:00
New Revision: 4f76d16203a83627f8541385e1fe082ecd920e77
URL: https://github.com/llvm/llvm-project/commit/4f76d16203a83627f8541385e1fe082ecd920e77
DIFF: https://github.com/llvm/llvm-project/commit/4f76d16203a83627f8541385e1fe082ecd920e77.diff
LOG: [libc] Implement iswgraph entrypoint (#185339)
part of https://github.com/llvm/llvm-project/issues/185136;
This PR adds public entrypoints for the wide character classification
function iswgraph in LLVM libc, using the same pattern as the existing
iswalpha entrypoint.
using bellow cmd to test:
```shell
ninja libc.test.src.wctype.iswgraph_test.__unit__
```
Added:
libc/src/wctype/iswgraph.cpp
libc/src/wctype/iswgraph.h
libc/test/src/wctype/iswgraph_test.cpp
Modified:
libc/config/baremetal/arm/entrypoints.txt
libc/config/baremetal/riscv/entrypoints.txt
libc/config/darwin/aarch64/entrypoints.txt
libc/config/linux/aarch64/entrypoints.txt
libc/config/linux/arm/entrypoints.txt
libc/config/linux/riscv/entrypoints.txt
libc/config/linux/x86_64/entrypoints.txt
libc/config/windows/entrypoints.txt
libc/include/wctype.yaml
libc/src/wctype/CMakeLists.txt
libc/test/src/wctype/CMakeLists.txt
Removed:
################################################################################
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index f45ee7a9052f4..3731f4341163d 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -299,6 +299,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
libc.src.wctype.iswcntrl
libc.src.wctype.iswdigit
libc.src.wctype.iswlower
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index 76e10e7d26a0a..35598afd527e1 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -296,6 +296,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
libc.src.wctype.iswcntrl
libc.src.wctype.iswdigit
libc.src.wctype.iswlower
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index 4f5fc6831dd3f..dccbba529f77e 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -102,6 +102,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
libc.src.wctype.iswcntrl
libc.src.wctype.iswdigit
libc.src.wctype.iswlower
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 08b45ad190627..6d90052164eab 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -369,6 +369,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
libc.src.wctype.iswcntrl
libc.src.wctype.iswdigit
libc.src.wctype.iswlower
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 042247e549340..66634f0e86bb4 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -194,6 +194,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
libc.src.wctype.iswcntrl
libc.src.wctype.iswdigit
libc.src.wctype.iswlower
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 1a4e85292c517..38f38bd105355 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -373,6 +373,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
libc.src.wctype.iswcntrl
libc.src.wctype.iswdigit
libc.src.wctype.iswlower
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 57d482dba9271..860795dbf77ba 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -418,6 +418,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
libc.src.wctype.iswcntrl
libc.src.wctype.iswdigit
libc.src.wctype.iswlower
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index 7e18a4d8b18d8..3a0ee3c5e3e73 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -108,6 +108,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
libc.src.wctype.iswcntrl
libc.src.wctype.iswlower
libc.src.wctype.iswspace
diff --git a/libc/include/wctype.yaml b/libc/include/wctype.yaml
index 2c6531bafc2ce..c2432e235330f 100644
--- a/libc/include/wctype.yaml
+++ b/libc/include/wctype.yaml
@@ -14,6 +14,12 @@ functions:
return_type: int
arguments:
- type: wint_t
+ - name: iswgraph
+ standards:
+ - stdc
+ return_type: int
+ arguments:
+ - type: wint_t
- name: iswlower
standards:
- stdc
diff --git a/libc/src/wctype/CMakeLists.txt b/libc/src/wctype/CMakeLists.txt
index 7dcbf84ab1c85..f93081f05f85a 100644
--- a/libc/src/wctype/CMakeLists.txt
+++ b/libc/src/wctype/CMakeLists.txt
@@ -29,6 +29,18 @@ add_entrypoint_object(
libc.src.__support.wctype_utils
)
+add_entrypoint_object(
+ iswgraph
+ SRCS
+ iswgraph.cpp
+ HDRS
+ iswgraph.h
+ DEPENDS
+ libc.src.__support.common
+ libc.src.__support.wctype_utils
+ libc.hdr.types.wint_t
+)
+
add_entrypoint_object(
iswlower
SRCS
diff --git a/libc/src/wctype/iswgraph.cpp b/libc/src/wctype/iswgraph.cpp
new file mode 100644
index 0000000000000..bfdb56cf766ca
--- /dev/null
+++ b/libc/src/wctype/iswgraph.cpp
@@ -0,0 +1,21 @@
+//===-- Implementation of iswgraph ----------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/wctype/iswgraph.h"
+#include "src/__support/common.h"
+#include "src/__support/wctype_utils.h"
+
+#include "hdr/types/wint_t.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+LLVM_LIBC_FUNCTION(int, iswgraph, (wint_t c)) {
+ return internal::isgraph(static_cast<wchar_t>(c));
+}
+
+} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/wctype/iswgraph.h b/libc/src/wctype/iswgraph.h
new file mode 100644
index 0000000000000..24dfa57bc2466
--- /dev/null
+++ b/libc/src/wctype/iswgraph.h
@@ -0,0 +1,21 @@
+//===-- Implementation header for iswgraph ----------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_WCTYPE_ISWGRAPH_H
+#define LLVM_LIBC_SRC_WCTYPE_ISWGRAPH_H
+
+#include "hdr/types/wint_t.h"
+#include "src/__support/common.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+int iswgraph(wint_t c);
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC_WCTYPE_ISWGRAPH_H
diff --git a/libc/test/src/wctype/CMakeLists.txt b/libc/test/src/wctype/CMakeLists.txt
index 1538fdf92da65..b7934192e7f82 100644
--- a/libc/test/src/wctype/CMakeLists.txt
+++ b/libc/test/src/wctype/CMakeLists.txt
@@ -32,6 +32,16 @@ add_libc_test(
libc.src.wctype.iswcntrl
)
+add_libc_test(
+ iswgraph_test
+ SUITE
+ libc_wctype_unittests
+ SRCS
+ iswgraph_test.cpp
+ DEPENDS
+ libc.src.wctype.iswgraph
+)
+
add_libc_test(
iswlower_test
SUITE
diff --git a/libc/test/src/wctype/iswgraph_test.cpp b/libc/test/src/wctype/iswgraph_test.cpp
new file mode 100644
index 0000000000000..125f3fffd4db3
--- /dev/null
+++ b/libc/test/src/wctype/iswgraph_test.cpp
@@ -0,0 +1,25 @@
+//===-- Unittests for iswgraph --------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/wctype/iswgraph.h"
+
+#include "test/UnitTest/Test.h"
+
+TEST(LlvmLibciswgraph, SimpleTest) {
+ EXPECT_NE(LIBC_NAMESPACE::iswgraph('a'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswgraph('0'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswgraph('?'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswgraph('!'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswgraph('~'), 0);
+
+ EXPECT_EQ(LIBC_NAMESPACE::iswgraph(' '), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswgraph('\t'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswgraph('\n'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswgraph('\0'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswgraph(-1), 0);
+}
More information about the libc-commits
mailing list