[libc-commits] [libc] [libc] Implement iswgraph entrypoint (PR #185339)
via libc-commits
libc-commits at lists.llvm.org
Sun Mar 8 19:57:58 PDT 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
@llvm/pr-subscribers-backend-risc-v
Author: Xinlong Chen (Xinlong-Chen)
<details>
<summary>Changes</summary>
part of https://github.com/llvm/llvm-project/issues/185136;
implement `iswgraph` entrypoint;
using bellow cmd to test:
```shell
ninja libc.test.src.wctype.iswgraph_test.__unit__
```
---
Full diff: https://github.com/llvm/llvm-project/pull/185339.diff
14 Files Affected:
- (modified) libc/config/baremetal/arm/entrypoints.txt (+1)
- (modified) libc/config/baremetal/riscv/entrypoints.txt (+1)
- (modified) libc/config/darwin/aarch64/entrypoints.txt (+1)
- (modified) libc/config/linux/aarch64/entrypoints.txt (+1)
- (modified) libc/config/linux/arm/entrypoints.txt (+1)
- (modified) libc/config/linux/riscv/entrypoints.txt (+1)
- (modified) libc/config/linux/x86_64/entrypoints.txt (+1)
- (modified) libc/config/windows/entrypoints.txt (+1)
- (modified) libc/include/wctype.yaml (+6)
- (modified) libc/src/wctype/CMakeLists.txt (+10)
- (added) libc/src/wctype/iswgraph.cpp (+21)
- (added) libc/src/wctype/iswgraph.h (+21)
- (modified) libc/test/src/wctype/CMakeLists.txt (+10)
- (added) libc/test/src/wctype/iswgraph_test.cpp (+25)
``````````diff
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index 7bc92e84b7fa4..deaaffaa88495 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -299,6 +299,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
# internal entrypoints
libc.startup.baremetal.init
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index 29be47dfbfd53..9bc2fc527f573 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -296,6 +296,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
# internal entrypoints
libc.startup.baremetal.init
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index b4a1ee70764cb..473b3244fb5e0 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -102,6 +102,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
)
if(LLVM_LIBC_FULL_BUILD)
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 960958b7cf90a..eb1566c318d4c 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -369,6 +369,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
# sys/uio.h entrypoints
libc.src.sys.uio.writev
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index e76bf81670ce5..22d0bdcb24e10 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -194,6 +194,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
)
if(LLVM_LIBC_FULL_BUILD)
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index a69d1a1b0a642..33033be9bfa8b 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -373,6 +373,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
# sys/uio.h entrypoints
libc.src.sys.uio.writev
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 4103ee0331a23..baeffc09242f4 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -418,6 +418,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
# sys/uio.h entrypoints
libc.src.sys.uio.writev
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index f777fc6c94bc2..4ed420b9bd4a9 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -108,6 +108,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswgraph
)
set(TARGET_LIBM_ENTRYPOINTS
diff --git a/libc/include/wctype.yaml b/libc/include/wctype.yaml
index fb4f96f7d17e4..fe0ceeca36f4b 100644
--- a/libc/include/wctype.yaml
+++ b/libc/include/wctype.yaml
@@ -8,3 +8,9 @@ functions:
return_type: int
arguments:
- type: wint_t
+ - name: iswgraph
+ standards:
+ - stdc
+ return_type: int
+ arguments:
+ - type: wint_t
\ No newline at end of file
diff --git a/libc/src/wctype/CMakeLists.txt b/libc/src/wctype/CMakeLists.txt
index 3ac5eaef8ed8b..9f9392acb60e2 100644
--- a/libc/src/wctype/CMakeLists.txt
+++ b/libc/src/wctype/CMakeLists.txt
@@ -7,3 +7,13 @@ add_entrypoint_object(
DEPENDS
libc.src.__support.wctype_utils
)
+
+add_entrypoint_object(
+ iswgraph
+ SRCS
+ iswgraph.cpp
+ HDRS
+ iswgraph.h
+ DEPENDS
+ libc.src.__support.wctype_utils
+)
diff --git a/libc/src/wctype/iswgraph.cpp b/libc/src/wctype/iswgraph.cpp
new file mode 100644
index 0000000000000..bfdb56cf766ca
--- /dev/null
+++ b/libc/src/wctype/iswgraph.cpp
@@ -0,0 +1,21 @@
+//===-- Implementation of iswgraph ----------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/wctype/iswgraph.h"
+#include "src/__support/common.h"
+#include "src/__support/wctype_utils.h"
+
+#include "hdr/types/wint_t.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+LLVM_LIBC_FUNCTION(int, iswgraph, (wint_t c)) {
+ return internal::isgraph(static_cast<wchar_t>(c));
+}
+
+} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/wctype/iswgraph.h b/libc/src/wctype/iswgraph.h
new file mode 100644
index 0000000000000..24dfa57bc2466
--- /dev/null
+++ b/libc/src/wctype/iswgraph.h
@@ -0,0 +1,21 @@
+//===-- Implementation header for iswgraph ----------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_WCTYPE_ISWGRAPH_H
+#define LLVM_LIBC_SRC_WCTYPE_ISWGRAPH_H
+
+#include "hdr/types/wint_t.h"
+#include "src/__support/common.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+int iswgraph(wint_t c);
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC_WCTYPE_ISWGRAPH_H
diff --git a/libc/test/src/wctype/CMakeLists.txt b/libc/test/src/wctype/CMakeLists.txt
index 5459cdb4a9b71..90501f561568e 100644
--- a/libc/test/src/wctype/CMakeLists.txt
+++ b/libc/test/src/wctype/CMakeLists.txt
@@ -9,3 +9,13 @@ add_libc_test(
DEPENDS
libc.src.wctype.iswalpha
)
+
+add_libc_test(
+ iswgraph_test
+ SUITE
+ libc_wctype_unittests
+ SRCS
+ iswgraph_test.cpp
+ DEPENDS
+ libc.src.wctype.iswgraph
+)
diff --git a/libc/test/src/wctype/iswgraph_test.cpp b/libc/test/src/wctype/iswgraph_test.cpp
new file mode 100644
index 0000000000000..125f3fffd4db3
--- /dev/null
+++ b/libc/test/src/wctype/iswgraph_test.cpp
@@ -0,0 +1,25 @@
+//===-- Unittests for iswgraph --------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/wctype/iswgraph.h"
+
+#include "test/UnitTest/Test.h"
+
+TEST(LlvmLibciswgraph, SimpleTest) {
+ EXPECT_NE(LIBC_NAMESPACE::iswgraph('a'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswgraph('0'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswgraph('?'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswgraph('!'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswgraph('~'), 0);
+
+ EXPECT_EQ(LIBC_NAMESPACE::iswgraph(' '), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswgraph('\t'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswgraph('\n'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswgraph('\0'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswgraph(-1), 0);
+}
``````````
</details>
https://github.com/llvm/llvm-project/pull/185339
More information about the libc-commits
mailing list