[libc-commits] [libc] [libc] Use explicit cast to time_t in utimes_test. (PR #185307)
Alexey Samsonov via libc-commits
libc-commits at lists.llvm.org
Sun Mar 8 10:56:04 PDT 2026
https://github.com/vonosmas created https://github.com/llvm/llvm-project/pull/185307
This fixes an error on RISCV-32 bot, where time_t is "long long" type (64-bit, as required by POSIX), instead of "long".
>From 0e2c2546d4e7db17d19bef6beffae87ad72b567e Mon Sep 17 00:00:00 2001
From: Alexey Samsonov <vonosmas at gmail.com>
Date: Sun, 8 Mar 2026 17:53:57 +0000
Subject: [PATCH] [libc] Use explicit cast to time_t in utimes_test.
This fixes an error on RISCV-32 bot, where time_t is "long long" type
(64-bit, as required by POSIX), instead of "long".
---
libc/test/src/sys/time/utimes_test.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libc/test/src/sys/time/utimes_test.cpp b/libc/test/src/sys/time/utimes_test.cpp
index 944c13d8f9170..3c8688ebda8d9 100644
--- a/libc/test/src/sys/time/utimes_test.cpp
+++ b/libc/test/src/sys/time/utimes_test.cpp
@@ -50,7 +50,7 @@ TEST_F(LlvmLibcUtimesTest, ChangeTimesSpecific) {
// seconds
ASSERT_EQ(statbuf.st_atim.tv_sec, times[0].tv_sec);
ASSERT_EQ(statbuf.st_mtim.tv_sec, times[1].tv_sec);
- ASSERT_GT(statbuf.st_ctim.tv_sec, 0L);
+ ASSERT_GT(statbuf.st_ctim.tv_sec, static_cast<time_t>(0));
// microseconds
ASSERT_EQ(statbuf.st_atim.tv_nsec,
@@ -61,7 +61,7 @@ TEST_F(LlvmLibcUtimesTest, ChangeTimesSpecific) {
// legacy way to check seconds
ASSERT_EQ(statbuf.st_atime, times[0].tv_sec);
ASSERT_EQ(statbuf.st_mtime, times[1].tv_sec);
- ASSERT_GT(statbuf.st_ctime, 0L);
+ ASSERT_GT(statbuf.st_ctime, static_cast<time_t>(0));
ASSERT_THAT(LIBC_NAMESPACE::remove(TEST_FILE), Succeeds(0));
}
More information about the libc-commits
mailing list