[libc-commits] [libc] [libc] implement iswcntrl support (PR #185273)
via libc-commits
libc-commits at lists.llvm.org
Sun Mar 8 05:28:10 PDT 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: None (valium007)
<details>
<summary>Changes</summary>
Implement iswcntrl entrypoint and test for #<!-- -->185136
---
Full diff: https://github.com/llvm/llvm-project/pull/185273.diff
14 Files Affected:
- (modified) libc/config/baremetal/arm/entrypoints.txt (+1)
- (modified) libc/config/baremetal/riscv/entrypoints.txt (+1)
- (modified) libc/config/darwin/aarch64/entrypoints.txt (+1)
- (modified) libc/config/linux/aarch64/entrypoints.txt (+1)
- (modified) libc/config/linux/arm/entrypoints.txt (+1)
- (modified) libc/config/linux/riscv/entrypoints.txt (+1)
- (modified) libc/config/linux/x86_64/entrypoints.txt (+1)
- (modified) libc/config/windows/entrypoints.txt (+1)
- (modified) libc/include/wctype.yaml (+6)
- (modified) libc/src/wctype/CMakeLists.txt (+10)
- (added) libc/src/wctype/iswcntrl.cpp (+21)
- (added) libc/src/wctype/iswcntrl.h (+21)
- (modified) libc/test/src/wctype/CMakeLists.txt (+10)
- (added) libc/test/src/wctype/iswcntrl_test.cpp (+31)
``````````diff
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index 7bc92e84b7fa4..c9b69a5b594d4 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -299,6 +299,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswcntrl
# internal entrypoints
libc.startup.baremetal.init
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index 29be47dfbfd53..9e5f2e2f725ba 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -296,6 +296,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswcntrl
# internal entrypoints
libc.startup.baremetal.init
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index b4a1ee70764cb..b0399398fae9f 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -102,6 +102,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswcntrl
)
if(LLVM_LIBC_FULL_BUILD)
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 960958b7cf90a..53276c58fd91b 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -369,6 +369,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswcntrl
# sys/uio.h entrypoints
libc.src.sys.uio.writev
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index e76bf81670ce5..5a328f2a2f9db 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -194,6 +194,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswcntrl
)
if(LLVM_LIBC_FULL_BUILD)
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index a69d1a1b0a642..9fbee113906ce 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -373,6 +373,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswcntrl
# sys/uio.h entrypoints
libc.src.sys.uio.writev
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 4103ee0331a23..a8585fe8ba42e 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -418,6 +418,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswcntrl
# sys/uio.h entrypoints
libc.src.sys.uio.writev
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index f777fc6c94bc2..10608b7f64ccc 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -108,6 +108,7 @@ set(TARGET_LIBC_ENTRYPOINTS
# wctype.h entrypoints
libc.src.wctype.iswalpha
+ libc.src.wctype.iswcntrl
)
set(TARGET_LIBM_ENTRYPOINTS
diff --git a/libc/include/wctype.yaml b/libc/include/wctype.yaml
index fb4f96f7d17e4..57c164d00fcba 100644
--- a/libc/include/wctype.yaml
+++ b/libc/include/wctype.yaml
@@ -8,3 +8,9 @@ functions:
return_type: int
arguments:
- type: wint_t
+ - name: iswcntrl
+ standards:
+ - stdc
+ return_type: int
+ arguments:
+ - type: wint_t
\ No newline at end of file
diff --git a/libc/src/wctype/CMakeLists.txt b/libc/src/wctype/CMakeLists.txt
index 3ac5eaef8ed8b..00c3b92c9e579 100644
--- a/libc/src/wctype/CMakeLists.txt
+++ b/libc/src/wctype/CMakeLists.txt
@@ -7,3 +7,13 @@ add_entrypoint_object(
DEPENDS
libc.src.__support.wctype_utils
)
+
+add_entrypoint_object(
+ iswcntrl
+ SRCS
+ iswcntrl.cpp
+ HDRS
+ iswcntrl.h
+ DEPENDS
+ libc.src.__support.wctype_utils
+)
\ No newline at end of file
diff --git a/libc/src/wctype/iswcntrl.cpp b/libc/src/wctype/iswcntrl.cpp
new file mode 100644
index 0000000000000..3562c3c5bf882
--- /dev/null
+++ b/libc/src/wctype/iswcntrl.cpp
@@ -0,0 +1,21 @@
+//===-- Implementation of iswcntrl ----------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/wctype/iswcntrl.h"
+#include "src/__support/common.h"
+#include "src/__support/wctype_utils.h"
+
+#include "hdr/types/wint_t.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+LLVM_LIBC_FUNCTION(int, iswcntrl, (wint_t c)) {
+ return internal::isupper(static_cast<wchar_t>(c));
+}
+
+} // namespace LIBC_NAMESPACE_DECL
\ No newline at end of file
diff --git a/libc/src/wctype/iswcntrl.h b/libc/src/wctype/iswcntrl.h
new file mode 100644
index 0000000000000..f4eaee60ed444
--- /dev/null
+++ b/libc/src/wctype/iswcntrl.h
@@ -0,0 +1,21 @@
+//===-- Implementation header for iswcntrl ----------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_WCTYPE_ISWCNTRL_H
+#define LLVM_LIBC_SRC_WCTYPE_ISWCNTRL_H
+
+#include "hdr/types/wint_t.h"
+#include "src/__support/common.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+int iswcntrl(wint_t c);
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC_WCTYPE_ISWCNTRL_H
\ No newline at end of file
diff --git a/libc/test/src/wctype/CMakeLists.txt b/libc/test/src/wctype/CMakeLists.txt
index 5459cdb4a9b71..7680a758743d6 100644
--- a/libc/test/src/wctype/CMakeLists.txt
+++ b/libc/test/src/wctype/CMakeLists.txt
@@ -9,3 +9,13 @@ add_libc_test(
DEPENDS
libc.src.wctype.iswalpha
)
+
+add_libc_test(
+ iswcntrl_test
+ SUITE
+ libc_wctype_unittests
+ SRCS
+ iswcntrl_test.cpp
+ DEPENDS
+ libc.src.wctype.iswcntrl
+)
\ No newline at end of file
diff --git a/libc/test/src/wctype/iswcntrl_test.cpp b/libc/test/src/wctype/iswcntrl_test.cpp
new file mode 100644
index 0000000000000..af15759aa0466
--- /dev/null
+++ b/libc/test/src/wctype/iswcntrl_test.cpp
@@ -0,0 +1,31 @@
+//===-- Unittests for iswcntrl --------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/wctype/iswcntrl.h"
+
+#include "test/UnitTest/Test.h"
+
+TEST(LlvmLibciswcntrl, DefaultLocale) {
+ EXPECT_NE(LIBC_NAMESPACE::iswcntrl(L'\0'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswcntrl(L'\t'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswcntrl(L'\n'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswcntrl(L'\v'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswcntrl(L'\f'), 0);
+ EXPECT_NE(LIBC_NAMESPACE::iswcntrl(L'\r'), 0);
+
+ EXPECT_EQ(LIBC_NAMESPACE::iswcntrl(L' '), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswcntrl(L'!'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswcntrl(L'0'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswcntrl(L'9'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswcntrl(L'A'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswcntrl(L'Z'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswcntrl(L'a'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswcntrl(L'z'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswcntrl(L'?'), 0);
+ EXPECT_EQ(LIBC_NAMESPACE::iswcntrl(L'~'), 0);
+}
\ No newline at end of file
``````````
</details>
https://github.com/llvm/llvm-project/pull/185273
More information about the libc-commits
mailing list