[libc-commits] [libc] [libc] Replace check-libc with lit-based test execution (PR #184163)
Jeff Bailey via libc-commits
libc-commits at lists.llvm.org
Wed Mar 4 01:54:54 PST 2026
https://github.com/kaladron updated https://github.com/llvm/llvm-project/pull/184163
>From 52c4202bbf3597c3832fdb5f2d1d78a0e12fb54e Mon Sep 17 00:00:00 2001
From: Jeff Bailey <jeffbailey at google.com>
Date: Mon, 2 Mar 2026 16:14:10 +0000
Subject: [PATCH 1/2] [libc] Replace check-libc with lit-based test execution
Now that check-libc-lit has been validated alongside check-libc,
make lit the default test runner by renaming check-libc-lit to
check-libc. Remove the old CMake-driven check-libc custom target.
---
libc/test/CMakeLists.txt | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libc/test/CMakeLists.txt b/libc/test/CMakeLists.txt
index beea3ad38466a..d7c3738a4ff95 100644
--- a/libc/test/CMakeLists.txt
+++ b/libc/test/CMakeLists.txt
@@ -1,7 +1,5 @@
-add_custom_target(check-libc)
add_custom_target(libc-unit-tests)
add_custom_target(libc-hermetic-tests)
-add_dependencies(check-libc libc-unit-tests libc-hermetic-tests)
add_custom_target(exhaustive-check-libc)
add_custom_target(libc-long-running-tests)
@@ -31,7 +29,7 @@ configure_lit_site_cfg(
"LIBC_GPU_LOADER_EXECUTABLE"
)
-add_lit_testsuite(check-libc-lit
+add_lit_testsuite(check-libc
"Running libc tests via lit"
${LIBC_BUILD_DIR}/test
DEPENDS libc-unit-tests-build libc-hermetic-tests-build
>From 1c649e3fd0980aacd53918013cb976f1f071b913 Mon Sep 17 00:00:00 2001
From: Jeff Bailey <jeffbailey at google.com>
Date: Tue, 3 Mar 2026 18:01:34 +0000
Subject: [PATCH 2/2] [libc] Remove old lit targets
---
libc/test/include/CMakeLists.txt | 1 -
libc/test/integration/CMakeLists.txt | 1 -
2 files changed, 2 deletions(-)
diff --git a/libc/test/include/CMakeLists.txt b/libc/test/include/CMakeLists.txt
index c1828f51c261e..3ac5615d7e209 100644
--- a/libc/test/include/CMakeLists.txt
+++ b/libc/test/include/CMakeLists.txt
@@ -1,6 +1,5 @@
add_custom_target(libc_include_tests)
add_dependencies(check-libc libc_include_tests)
-add_dependencies(check-libc-lit libc_include_tests)
add_libc_test(
assert_test
diff --git a/libc/test/integration/CMakeLists.txt b/libc/test/integration/CMakeLists.txt
index 9a7e9a57752e6..7dbcc9544a0b9 100644
--- a/libc/test/integration/CMakeLists.txt
+++ b/libc/test/integration/CMakeLists.txt
@@ -1,6 +1,5 @@
add_custom_target(libc-integration-tests)
add_dependencies(check-libc libc-integration-tests)
-add_dependencies(check-libc-lit libc-integration-tests)
function(add_libc_integration_test_suite name)
add_custom_target(${name})
More information about the libc-commits
mailing list