[libc-commits] [libc] [libc] Change cpp::string_view into cpp::basic_string_view<CharT> (PR #203355)
Alex Strelnikov via libc-commits
libc-commits at lists.llvm.org
Wed Jun 24 08:31:32 PDT 2026
strel-12 wrote:
> > Yeah, I'm also not the best person when it comes to local conventions. Waiting for Michael (or someone else) SGTM.
> > (FWIW, I like your solution from the other patch :P)
>
> My preference is generally to make debugging as easy as possible at the cost of test code size. When testing different types, if they have their own line then setting a breakpoint on the specific breakage is easier. That said, given that there are currently only 2 types for `string_view` and there are unlikely to be more than 5 I'd be okay with `TYPED_TEST` here.
Sounds good, parameterized the tests using a version of @labath's macro+template helper example.
https://github.com/llvm/llvm-project/pull/203355
More information about the libc-commits
mailing list