[libc-commits] [libc] [libc] Change cpp::string_view into cpp::basic_string_view<CharT> (PR #203355)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Tue Jun 23 16:57:48 PDT 2026


michaelrj-google wrote:

> Yeah, I'm also not the best person when it comes to local conventions. Waiting for Michael (or someone else) SGTM.
> 
> (FWIW, I like your solution from the other patch :P)

My preference is generally to make debugging as easy as possible at the cost of test code size. When testing different types, if they have their own line then setting a breakpoint on the specific breakage is easier. That said, given that there are currently only 2 types for `string_view` and there are unlikely to be more than 5 I'd be okay with `TYPED_TEST` here.

https://github.com/llvm/llvm-project/pull/203355


More information about the libc-commits mailing list