[libc-commits] [libc] [llvm] [LoongArch] Support ISD::SET_ROUNDING (llvm.set.rounding) (PR #205051)

Paper Moon via libc-commits libc-commits at lists.llvm.org
Tue Jun 23 01:53:12 PDT 2026


tangyuan0821 wrote:

> As mentioned in the previous review, this should be handled inside `Subtarget.hasBasicF()`: [#205051 (comment)](https://github.com/llvm/llvm-project/pull/205051#discussion_r3452169426) . Unless there is a compelling reason to move it outside, please keep it there.
> 
> Add the added test still clearly fails locally..
> 
> ```
> ./bin/llvm-lit ../llvm/test/CodeGen/LoongArch/set-rounding.ll
> -- Testing: 1 tests, 1 workers --
> FAIL: LLVM :: CodeGen/LoongArch/set-rounding.ll (1 of 1)
> ********************
> Failed Tests (1):
>   LLVM :: CodeGen/LoongArch/set-rounding.ll
> 
> Testing Time: 0.27s
> 
> Total Discovered Tests: 1
>   Failed: 1 (100.00%)
> ```
> 
> **IMPORTAN:** As stated in LLVM's AI Tool Policy, contributors must read and review all LLM-generated code or text before they ask other project members to review it: https://llvm.org/docs/AIToolPolicy.html

Moved SET_ROUNDING back inside hasBasicF(). Tests pass locally.

https://github.com/llvm/llvm-project/pull/205051


More information about the libc-commits mailing list