[libc-commits] [libc] [libc] Add remaining SO_ constants (PR #202278)

[Pavel Labath via libc-commits]

================
@@ -30,6 +30,12 @@
 
 #define SOL_SOCKET 1
 
+// The values of the following constants differ on some architectures
+#if defined(__parisc__) || defined(__alpha__) || defined(__sparc__) ||         \
----------------
labath wrote:

> I mean.. I've personally owned one of each of these in the last 2 decades...

I'm impressed :)

> I guess I'm more worried that this is a list of the ones we consider odd, which wont' be exhaustive and I worry about the pattern here if someone discovers that say, m68k (still in production!) also is odd.

A list of odd architectures (at least in this particular aspect) is kindof what I had in mind, but it should also kind of be exhaustive -- this are all the current architectures that define their own socket constants, and I'm hoping that newly introduced arches will use the generic numbering scheme.

https://github.com/llvm/llvm-project/pull/202278