[libc-commits] [libc] [libc] implement mkstemp (PR #199220)

[Hardik Chona via libc-commits]

un-pixelated wrote:

@michaelrj-google hey there
I've addressed the requested changes
Some things though:
1. turns out, not treating all Xs as a valid suffix breaks the POSIX spec, hence I've not implemented it. You said it was fine in our discord conversation but I'm still asking for confirmation here.
2. using the namespaced version of free causes a linker error, but using the system version of free does not. I've followed the pattern which other test files like strdup_test.cpp use ie using the system free rather than the libc one and my build succeeded
3. As discussed on discord, the change requested regarding testing the loop with 100% reliability is not included in this PR and a separate issue is to be made related to it. This is also relevant to point number 1.

With that out of the way, I request you to review this pull request.

https://github.com/llvm/llvm-project/pull/199220