[libc-commits] [libc] [llvm] [libc][math][c23] Add acosbf16 math function (PR #184633)
via libc-commits
libc-commits at lists.llvm.org
Sat Jun 6 12:52:07 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- libc/shared/math/acosbf16.h libc/src/__support/math/acosbf16.h libc/src/math/acosbf16.h libc/src/math/generic/acosbf16.cpp libc/test/src/math/acosbf16_test.cpp libc/test/src/math/smoke/acosbf16_test.cpp libc/shared/math.h libc/test/shared/shared_math_test.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libc/src/__support/math/acosbf16.h b/libc/src/__support/math/acosbf16.h
index 276399830..93c5ebc1e 100644
--- a/libc/src/__support/math/acosbf16.h
+++ b/libc/src/__support/math/acosbf16.h
@@ -66,8 +66,9 @@ LIBC_INLINE bfloat16 acosbf16(bfloat16 x) {
// and acos(x) = acos(|x|) for x >= 0, pi - acos(|x|) for x < 0
float t = fputil::multiply_add<float>(xf_abs, -0.5f, 0.5f);
float t_sqrt = fputil::sqrt<float>(t);
- // TODO: Use bfloat16 version for inv_trigf_utils_internals after they are available
- // Tracking issue : https://github.com/llvm/llvm-project/issues/202079
+ // TODO: Use bfloat16 version for inv_trigf_utils_internals after they are
+ // available Tracking issue :
+ // https://github.com/llvm/llvm-project/issues/202079
float tp = fputil::cast<float>(inv_trigf_utils_internal::asin_eval(t));
float asin_sqrt_t = t_sqrt * (fputil::multiply_add(t, tp, 1.0f));
``````````
</details>
https://github.com/llvm/llvm-project/pull/184633
More information about the libc-commits
mailing list