https://github.com/mysterymath commented: Some cursory thoughts; more in-depth review pending. For the change itself, the commit message should definitely mention what UB this is fixing and how it fixes it. https://github.com/llvm/llvm-project/pull/201001