[libc-commits] [libc] [libc] Remove redundant file(COPY) for x86_64 types (PR #201317)

[via libc-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Jeff Bailey (kaladron)

<details>
<summary>Changes</summary>

Removed the redundant file(COPY) command from the x86_64 architecture check in libc/include/llvm-libc-types/CMakeLists.txt.

This command eagerly copies the x86_64 directory to the binary directory, which is redundant because individual headers are already copied by their respective add_header targets. It also preserved read-only depot permissions from the source tree, making the build directory read-only and causing rm -rf to fail.

Assisted-by: Automated tooling, human reviewed.

---
Full diff: https://github.com/llvm/llvm-project/pull/201317.diff


1 Files Affected:

- (modified) libc/include/llvm-libc-types/CMakeLists.txt (-1) 


``````````diff
diff --git a/libc/include/llvm-libc-types/CMakeLists.txt b/libc/include/llvm-libc-types/CMakeLists.txt
index c1b35fce166a7..c1f344aacdfa1 100644
--- a/libc/include/llvm-libc-types/CMakeLists.txt
+++ b/libc/include/llvm-libc-types/CMakeLists.txt
@@ -133,7 +133,6 @@ set(mcontext_deps)
 set(ucontext_deps .sigset_t .stack_t)
 
 if(LIBC_TARGET_ARCHITECTURE STREQUAL "x86_64")
-  file(COPY x86_64 DESTINATION ${CMAKE_CURRENT_BINARY_DIR})
   add_header(
     mcontext_t_arch
     HDR

``````````

</details>


https://github.com/llvm/llvm-project/pull/201317