[libc-commits] [libc] [libc] Remove redundant file(COPY) for x86_64 types (PR #201317)

Jeff Bailey via libc-commits libc-commits at lists.llvm.org
Wed Jun 3 04:01:40 PDT 2026


https://github.com/kaladron created https://github.com/llvm/llvm-project/pull/201317

Removed the redundant file(COPY) command from the x86_64 architecture check in libc/include/llvm-libc-types/CMakeLists.txt.

This command eagerly copies the x86_64 directory to the binary directory, which is redundant because individual headers are already copied by their respective add_header targets. It also preserved read-only depot permissions from the source tree, making the build directory read-only and causing rm -rf to fail.

Assisted-by: Automated tooling, human reviewed.

>From 3bb2fdd8a756d6060027242b51221e4fe2bb5a55 Mon Sep 17 00:00:00 2001
From: Jeff Bailey <jbailey at raspberryginger.com>
Date: Wed, 3 Jun 2026 10:03:59 +0100
Subject: [PATCH] [libc] Remove redundant file(COPY) for x86_64 types

Removed the redundant file(COPY) command from the x86_64 architecture
check in libc/include/llvm-libc-types/CMakeLists.txt.

This command eagerly copies the x86_64 directory to the binary
directory, which is redundant because individual headers are already
copied by their respective add_header targets. It also preserved
read-only depot permissions from the source tree, making the build
directory read-only and causing rm -rf to fail.

Assisted-by: Automated tooling, human reviewed.
---
 libc/include/llvm-libc-types/CMakeLists.txt | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libc/include/llvm-libc-types/CMakeLists.txt b/libc/include/llvm-libc-types/CMakeLists.txt
index c1b35fce166a7..c1f344aacdfa1 100644
--- a/libc/include/llvm-libc-types/CMakeLists.txt
+++ b/libc/include/llvm-libc-types/CMakeLists.txt
@@ -133,7 +133,6 @@ set(mcontext_deps)
 set(ucontext_deps .sigset_t .stack_t)
 
 if(LIBC_TARGET_ARCHITECTURE STREQUAL "x86_64")
-  file(COPY x86_64 DESTINATION ${CMAKE_CURRENT_BINARY_DIR})
   add_header(
     mcontext_t_arch
     HDR



More information about the libc-commits mailing list