[libc-commits] [libc] [libc][benchmark] allow benchmark to be built without llvm support (PR #200951)

[Jeff Bailey via libc-commits]

================
@@ -141,54 +184,56 @@ add_libc_benchmark_unittest(libc-memory-benchmark-test
     DEPENDS libc-memory-benchmark
 )
 
-# json
-add_library(json
-    STATIC
-    EXCLUDE_FROM_ALL
-    JSON.cpp
-    JSON.h
-)
-target_link_libraries(json PUBLIC libc-memory-benchmark)
-llvm_update_compile_flags(json)
+if(LIBC_BENCHMARKS_HAS_LLVM_SUPPORT)
----------------
kaladron wrote:

This is a really long stretch and I worry about how complicated our CMakeFiles are.   I'm curious if you have an opinon on how this could be done better so that a human reading it has a hope of know whether something is included easily or not.

An if that's two pages off the screen is easy to forget.

https://github.com/llvm/llvm-project/pull/200951