[libc-commits] [libc] [libc] Add support for wchar_t in StringConverter. (PR #211867)

[Jeff Bailey via libc-commits]

https://github.com/kaladron approved this pull request.

Nice work getting this generalised!  A couple of minor things within.

Michael knows the wide character stuff better than I do.  It looks like `-fwide-exec-charset` is for changing the default character set for wide characters and that Clang generally supports the default per-arch and that GCC allows it to be overridden (for things like UTF-32 on Windows, or explicitly setting endianness, etc).  I found a couple of RFCs where it was discussed for Clang, but not anything conclusive around "we should or shouldn't do this"

My 2p is that I wouldn't worry about it until someone with a need for it shows up.  My guess is that there are a bunch of places we'd have to tweak to make it work so there's not much point in having some support bitrotting.

https://github.com/llvm/llvm-project/pull/211867