[libc-commits] [libc] [llvm] [libc] Fix libc GPU bitcode entrypoint library build on Windows (PR #210662)

[via libc-commits]

jinge90 wrote:

Hi, @jhuber6 
I found some other issues when testing this patch:
1. we introduce dependency on llvm-link for gpu target, so we need to add it to extra_deps in llvm/runtimes/CMakeLists.txt when LLVM_LIBC_GPU_BUILD

3. After fixing 1, the normal bootstrapping build work as expected but build fails when using cmake cache for gpu, the reason is amd team recently changes the libc target for amd gpu to 'amdgpu-amd-amdhsa' and the LLVM_LIBC_GPU_BUILD flag is set according to this new target name while 'amdgcn-amd-amdhsa' still used in cmake cache for gpu, this lead to LLVM_LIBC_GPU_BUILD not set, so all required extra_deps will be missed.

5. The pre-ci for amd gpu is standalone build and uses a pre-build dock image, llvm-link is not included in this image.
I wonder whether we should update the dock image for libc testing?
It looks like we need to firstly update libc Dockfile in https://github.com/llvm/llvm-project/blob/main/.github/workflows/containers/libc/Dockerfile , to install llvm-23 in the docker image to include llvm-link tool.
After the Dockfile merged and the docker image updated, we can proceed with current PR?

Thanks very much.


https://github.com/llvm/llvm-project/pull/210662