[libc-commits] [libc] [libc] Make getauxval test hermetic (PR #210706)

[Pavel Labath via libc-commits]

https://github.com/labath created https://github.com/llvm/llvm-project/pull/210706

None

>From 55beafa7ce83ab15183a51a15ebc1871bbfd6f7e Mon Sep 17 00:00:00 2001
From: Pavel Labath <pavel at labath.sk>
Date: Mon, 20 Jul 2026 12:49:57 +0000
Subject: [PATCH] [libc] Make getauxval test hermetic

---
 libc/test/UnitTest/HermeticTestUtils.cpp    | 8 --------
 libc/test/src/sys/auxv/linux/CMakeLists.txt | 2 +-
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/libc/test/UnitTest/HermeticTestUtils.cpp b/libc/test/UnitTest/HermeticTestUtils.cpp
index 5ce661b2202c0..f7fc52e87ecc8 100644
--- a/libc/test/UnitTest/HermeticTestUtils.cpp
+++ b/libc/test/UnitTest/HermeticTestUtils.cpp
@@ -25,14 +25,6 @@ void *memmove(void *dst, const void *src, size_t count);
 void *memset(void *ptr, int value, size_t count);
 int atexit(void (*func)(void));
 
-// TODO: It seems that some old test frameworks does not use
-// add_libc_hermetic_test properly. Such that they won't get correct linkage
-// against the object containing this function. We create a dummy function that
-// always returns 0 to indicate a failure.
-[[gnu::weak]] unsigned long getauxval([[maybe_unused]] unsigned long id) {
-  return 0;
-}
-
 } // namespace LIBC_NAMESPACE_DECL
 
 constexpr uint64_t ALIGNMENT = alignof(uintptr_t);
diff --git a/libc/test/src/sys/auxv/linux/CMakeLists.txt b/libc/test/src/sys/auxv/linux/CMakeLists.txt
index e4c3b782cd326..92617049401a2 100644
--- a/libc/test/src/sys/auxv/linux/CMakeLists.txt
+++ b/libc/test/src/sys/auxv/linux/CMakeLists.txt
@@ -1,5 +1,5 @@
 add_custom_target(libc_sys_auxv_unittests)
-add_libc_unittest(
+add_libc_test(
   getauxval_test
   SUITE
     libc_sys_auxv_unittests