[libc-commits] [libc] [libc][docs] Add code review guidelines for libc PRs (PR #205730)

[Shubh Pachchigar via libc-commits]

shubhe25p wrote:

> > > I am also concerned about the duplication that this may introduce. This knowledge here could be used to expand https://libc.llvm.org/dev/index.html instead, for all developers and not only reviewers. The guidelines specific to _reviewing_ are IMO the same as LLVM as a whole and likely don't need reiterating in libc.
> > 
> > 
> > So do you think this is needed or can be closed?
> 
> My take is that I'd rather we close it. My experience is that docs like this wind up not being complete enough to help people review, and also create multiple sources of truth and cause confusion.
> 
> What I would love is us fixing up the existing docs more if there are things to be done. I originaly had a 6-step plan for reworking the site. I think I stalled out at step 3 and it will be too out of date to keep going at this point so would need to be redone.
> 
> So that's the question: what's needed? When you try to do things, what do you have trouble finding? Only beginners can really help us find the gaps so if you're new to an area, feedback is appreciated!

Yeah sure no worries, I am not sure I was looking for a guide but I think I will get started with reviewing and learn from what the maintainers flag and go from there.

https://github.com/llvm/llvm-project/pull/205730