[libc-commits] [libc] [libc][realpath][test] Create test files/directories (PR #209369)
Jeff Bailey via libc-commits
libc-commits at lists.llvm.org
Mon Jul 13 22:45:56 PDT 2026
kaladron wrote:
Pavel has a PR in progress that fixes the memory release problem. Should
we hold for that?
Jeff Bailey
Circus Ringmaster
***@***.***
On Tue, 14 Jul 2026, 05:33 Jackson Stogel, ***@***.***> wrote:
> Follow-up PRs will add path validation etc to realpath, which will
> require paths to exist in the filesystem.
>
> This PR bumps the memory limit in HermeticTestUtils.cpp. The realpath
> unit tests allocate quite a few strings, and since memory in hermetic tests
> is never freed, the unit test quickly reaches the limit.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/llvm/llvm-project/pull/209369
> Commit Summary
>
> - 0366b21
> <https://github.com/llvm/llvm-project/pull/209369/commits/0366b21513e799639d7b1f9d3f6ae4fbf075752e>
> [libc][realpath][test] Create test files/directories
>
> File Changes
>
> (3 files <https://github.com/llvm/llvm-project/pull/209369/files>)
>
> - *M* libc/test/UnitTest/HermeticTestUtils.cpp
> <https://github.com/llvm/llvm-project/pull/209369/files#diff-c955a9034cfa5a3e42db4c082c86f5785d64919cfb4edb89c826e605544cf66a>
> (2)
> - *M* libc/test/src/stdlib/CMakeLists.txt
> <https://github.com/llvm/llvm-project/pull/209369/files#diff-2ff976c66b608d47f13b99f791227a4b65114d1247693c2076e2e245498828fa>
> (10)
> - *M* libc/test/src/stdlib/realpath_test.cpp
> <https://github.com/llvm/llvm-project/pull/209369/files#diff-aca6824b58e4f04332d87d69029ae6599f1ffe687b80364df168c5cf34255484>
> (244)
>
> Patch Links:
>
> - https://github.com/llvm/llvm-project/pull/209369.patch
> - https://github.com/llvm/llvm-project/pull/209369.diff
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/209369?email_source=notifications&email_token=AAC4FO77G7VMGB77PN2W3GT5EWZZTA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42DANBZGY4DCNRZGKTHEZLBONXW5MDSMV3GSZLXL5ZGK4LVMVZXIZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAC4FOZDGQQN7TOARQQZS2D5EWZZTAVCNFSNUABEKJSXA33TNF2G64TZHM3TKOBSGE2DGMR3JFZXG5LFHM2DQNZZHA3DMOJZGGQXMAQ>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
https://github.com/llvm/llvm-project/pull/209369
More information about the libc-commits
mailing list