[libc-commits] [libc] [libc][bazel] Append '/' to TEST_UNDECLARED_OUTPUTS_DIR (PR #207710)

Pavel Labath via libc-commits libc-commits at lists.llvm.org
Wed Jul 8 06:29:50 PDT 2026


================
@@ -23,9 +23,9 @@ CString libc_make_test_file_path_func(const char *file_name) {
   // Do something sensible if not run under bazel, otherwise this may segfault
   // when constructing the string.
   if (UNDECLARED_OUTPUTS_PATH == nullptr)
-    UNDECLARED_OUTPUTS_PATH = "";
+    return cpp::string(file_name);
----------------
labath wrote:

No, file_name will typically be a bare name without a directory component. The goal of this code is to produce a path in the current directory if TEST_UNDECLARED_OUTPUTS_DIR is not set. Previously it achieved that by concatenating the empty string with the file_name. Now, it returns file_name directly.

https://github.com/llvm/llvm-project/pull/207710


More information about the libc-commits mailing list