[libc-commits] [libc] [libc][docs] Add code review guidelines for libc PRs (PR #205730)

[Shubh Pachchigar via libc-commits]

shubhe25p wrote:

> Hi! Thanks for doing this! Three questions:
> 
> 1. Did you fix the private email address that got flagged?

Hi Yes it is fixed.

> 2. Can you tell me a bit more about why you've put this together?  I worry that this is duplicative to the other style guides in the project and that we'll wind up with gaps between them.

I wanted to help with reviews of libc PRs but didn't find any guidelines so @michaelrj-google suggested to create a doc which the maintainers will help refine. I think this would help anyone jump in to help.

> 3. Can you please tell me about how you derived these?  (Like, what analysis was done, and what patterns did you find / did you find things that aren't covered by other parts of the style guide?

Mostly based on my PRs and some Copilot generated. I will make it even more smaller to start with and expand from there.
> 
> Thank you!


https://github.com/llvm/llvm-project/pull/205730